Disable module before upgrading

It is good to know. I was not aware about this problem.

But at first glance i do not understand what happened to you at upgrade, because term_access tables, and 'node_access' table has not changed from 4.6 to 4.7. (Only utf-8 conversion, but this should not affect it IMO). So i do not understand what have caused the problem to you. (Of course legacy module 4.6 will not work at version 4.7).

there was some legacy 4.6 version of the module hanging around that I couldn't get past. For whatever reason, it doesn't start using the new module file, when it replaces the old one.

- What do you mean by that new module was not started?

Please describe, i am curious about it:
- Does your category permissions got corrupted at upgrade?
- At upgrade, have you deleted legacy 46 module, and overwritten it by 47 at the same directory?
- Did you apply database update for taxonomy_access with update.php?
Please tell me in more detail, i am curious about it

Anyway, for security reasons, it is better to be cautious. i will put your suggestions into update.txt file. Definitely it is good to do disable before update. Because at enable, a complete "housekeeping" happens with table "node_access", that is node_Access is completely regenerated acc. to category permissions (saved in table 'term_access').

Sorry, i messed up some html in the comment :(

I am not worried about the tables. Based on what you just said, nothing appeared to happen becasue nothing major happened. I guess I'm confusing issues a bit. Although, I did try to do a fresh install on a test server and it didn't work either- meaning it didn't create the tables.

With my REAL problem, nothing happens to current term access settings. (I dropped the tables, but there was nothing really wrong with them. I just expected something to change.) What really happens is that I cannot get into "settings" or "category permissions" pages becase it keeps trying to run the code in the old module file. I get forms API related fatal errors.

I found this out because I created a new term and wanted to change permissions on it and could NOT get into the "category permissions" page.

The old file no longer existed and was REPLACED by the new 4.7, forms API compliant one.

I did run update.php after unpacking and relacing the taxonomy_access.module file, but I can't recall if there was a message about taxonomy_access. I didn't get any error messages or anything.

UPDATE.txt: I put advice to deactivate and then disable the module when updating.