Misleading? - "Replace my user picture with the gravatar for my e-mail address."
| Project: | Gravatar integration |
| Version: | 6.x-1.7 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Hello,
I have read the other tickets here that seem to address the idea of user-uploaded pictures over-riding the Gravatar image, and vice versa. What's not clear is if/how those issues were resolved, or if a final decision was made on priority.
I have installed Gravatar 6.x-1.7 on my site, and enabled the "use gravatar" and "disable own gravatar" permissions for all users.
I have tested and seen the following:
So it would appear that the "Replace my user picture with the gravatar for my e-mail address" is misleading, because it doesn't override the user picture with the gravatar at all. In a way it ought to read "Show the Gravatar if I have no user picture uploaded"..... which the module should do automatically anyway....
I don't know much about PHP, but it would seem like there might be a problem with the logic in the code...
#1
Thanks for pointing this out. I committed a small change to the text to say "it will replace your current user picture unless you have uploaded a user picture." The logic of this will also be revamped with #464562: Add a permission to disable the user picture upload form.
#2
In my mind, "it will replace your current user picture unless you have uploaded a user picture" is still confusing. So if you haven't uploaded any picture, it (what exactly?) will be replaced by the Gravatar. What is the Gravatar replacing in this case?
#3
@WildBill That's not the text that will be displayed if the user has not uploaded a user picture.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.