Default File Name

I'd like to have this behaviour as default because if I upload a file that do not match the drupal naming convention (picture-uid.extension) my uploaded image will be deleted on the file system after a while. I don't know the reason why or after which time, but if I rename the local image to the drupal naming convention and then upload the file via avatar crop the picture stays in the filesystem.

I've done a dirty hack on this to generate a filename that matches the drupal naming conventions. The only difference between the default behaviour is, that the old files will not be replaced. Instead I respect the renaming like this: If user with uid 5 uploads his first picture the filename will be "picture-5.jpg". If he changes the picture, the following pictures will be named like this: "picture-5_0.jpg", "picture-5_1.jpg", "picture-5_2.jpg" and so on.

Here is what I have done in the file "avatarcrop.module" in Version 6.x-1.1
search the following line of code surround line 124:

$file = file_save_upload('file_upload', $validators, $dest);

then append the following code snippet:

  global $user;
  $owner=$user->uid;
  $filetype;
  $filetype = $file->filemime; 
	$extension='';
	switch ($filetype) {
		case 'image/jpeg':
      $extension='jpg';
			break;
		case 'image/png':
      $extension='png';
			break;
		case 'image/gif':
      $extension='gif';
			break;			
	}
  $dest = variable_get('user_picture_path', 'pictures') .'/picture-'. $owner .'.'. $extension;

For the last step, change "file_copy" with "file_move" in the following line of code:
Change From:
$result = file_copy($file, $dest, FILE_EXISTS_RENAME);

To this:
$result = file_move($file, $dest, FILE_EXISTS_RENAME);

That's done the trick for me.
cheers

Hello undoIT

Thank you for reply

I cannot confirm the same behavior on my site. If a user goes to upload a new avatar, the shown picture for cropping IS the pic that was chosen before from file system. Also after hitting continue, the correct picture is displayed in the user profile without the need of reloading the page. Perhaps it's because I'm using imagecache for image pre-processing and displaying user pics. Another issue could be the caching of the webpage. For my site I do not use any kind of drupal-caching.

A solution would be to delete first the user avatar from file system before uploading the new one. One problem could be, if the cropping process will be canceled no user avatar will be displayed anymore because of deleting it before. I'll do some research.

I do not think it's worth for filing a seperate bug

Hi again

Here's a possible solution for your problem

search and delete the following lines of your avatarcrop.module file

  $upload_dir=variable_get('user_picture_path','pictures');
  $filepath=file_directory_path();
  $dest = $filepath . '/' .$upload_dir;
  $file = file_save_upload('file_upload', $validators, $dest);
	global $user;
  $owner=$user->uid;
  $filetype;
  $filetype = $file->filemime; 
	$extension='';
	switch ($filetype) {
		case 'image/jpeg':
      $extension='jpg';
			break;
		case 'image/png':
      $extension='png';
			break;
		case 'image/gif':
      $extension='gif';
			break;			
	}
  $dest = variable_get('user_picture_path', 'pictures') .'/picture-'. $owner .'.'. $extension; 

and replace it with the following lines:

   global $user;
  $owner=$user->uid;
  $userpicpath = db_result(db_query("SELECT picture FROM {users} WHERE uid=%d",$owner));
  file_delete($userpicpath);
  $upload_dir=variable_get('user_picture_path','pictures');
  $filepath=file_directory_path();
  $dest = $filepath . '/' .$upload_dir;
  $file = file_save_upload('file_upload', $validators, $dest);
  $filetype;
  $filetype = $file->filemime; 
	$extension='';
	switch ($filetype) {
		case 'image/jpeg':
      $extension='jpg';
			break;
		case 'image/png':
      $extension='png';
			break;
		case 'image/gif':
      $extension='gif';
			break;			
	}
  $dest = variable_get('user_picture_path', 'pictures') .'/picture-'. $owner .'.'. $extension; 

Now, the old user avatar will be first deleted and afterwards the new one will be uploaded. So ther should always appear the new uploaded pic without the need of reloading.

Please test it and give feedback

cheers

Hi undoIT

Perhaps a refresh should be done by the module after uploading and after cropping an image. I'll have a look, if this is possible. But I cannot promise anything. My drupal module hacking skills aren't very good yet.

For me I went back to my first solution without deleting the user pic first because of a problem interacting with imagecache. But without imagecache the second solution should be better and more space-saving.

cheers

fixed in later versions.