Shouldn't the sidebar classes in maintenance.tpl.php be called sidebar-first and sidebar-second respectively, instead of sidebar-primary and sidebar-secondary?

CommentFileSizeAuthor
correct_sidebar_classes.patch1.12 KBkdebaas

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Wrong sidebar class naming in maintenance.tpl.php » Wrong sidebar class naming in maintenance-page.tpl.php
Status: Needs review » Fixed

Whoops! Good catch. We were trying out primary/secondary before we went with first/second.

And I totally missed changing it in the maintenance page.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.