Allow user to set update interval
timhill - August 10, 2009 - 22:08
| Project: | Browscap |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Patch adds a setting to browscap to allow user to determine how often browscap should check garykeith.com for new data. User can set the interval to any number of days, 7 days is still the default. Setting the number of days to 0 turns off updating.
| Attachment | Size |
|---|---|
| browscap-interval.patch | 2.72 KB |
#1
subscribe
#2
Can you explain the motivation for this? It feels like useless UI cruft to me, but I've just started using the module.
#3
It's a little crufty, I'll admit. My main motivation with the patch was to add the ability to turn off auto-updating. This is useful for situations where a server cannot "phone out" and for users who would like more direct control and would prefer to update the browscap file manually. I decided to make the patch able to set the update interval just in case someone still wanted auto-update but didn't want to "phone out" so often.
#4
I wanted to test this and had to re-roll it. I also tweaked the spacing on the multiplication. It seems good to me - can you confirm that it still works for you? If so then we could commit it.
#5
Sorry for the delay, the patch looks good, works in version 1.1