Download & Extend
Issues

Decouple System from Node

Posted by Xano on August 11, 2009 at 1:35am
Project:Drupal core
Version:8.x-dev
Component:system.module
Category:task
Priority:normal
Assigned:Xano
Status:needs work
Issue tags:makenodeoptional

Issue Summary

The attached patch makes System independent from Node. It is split off from #375397: Make Node module optional.

AttachmentSizeStatusTest resultOperations
node_decouple_system_03.patch16.65 KBIdleFailed: Invalid PHP syntax in modules/system/system.admin.inc.View details | Re-test
Login or register to post comments

Comments

#1

Posted by System Message on August 11, 2009 at 1:47am
Status:needs review» needs work

The last submitted patch failed testing.

#2

Posted by Xano on August 11, 2009 at 10:00am
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
node_decouple_system_04.patch16.68 KBIdleFailed: 11869 passes, 4 fails, 0 exceptionsView details | Re-test

#3

Posted by System Message on August 11, 2009 at 10:23am
Status:needs review» needs work

The last submitted patch failed testing.

#4

Posted by Xano on August 11, 2009 at 6:33pm
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
node_decouple_system_05.patch19.51 KBIdleFailed: Failed to apply patch.View details | Re-test

#5

Posted by Berdir on August 12, 2009 at 12:26pm
Status:needs review» needs work

+  db_query("DELETE FROM {variable} WHERE name LIKE 'node_%'");

That should be a db_delete() :)

+  variable_set('node_options_forum', array(0 => 'status'));

Hm.. I think that should actually be in forum.module ?

+      ->condition('link_title', array('Menu link #1-1', 'Menu link #2'), 'IN')

IN should be the default for an array, not necessary...

#6

Posted by Xano on August 12, 2009 at 1:38pm
Status:needs work» needs review

Grepping for "node_options_forum" only shows system.install. You're right, but it I think we're safe to remove that variable altogether in another patch.

AttachmentSizeStatusTest resultOperations
node_decouple_system_07.patch19.29 KBIdleFailed: Failed to apply patch.View details | Re-test

#7

Posted by System Message on August 12, 2009 at 1:48pm
Status:needs review» needs work

The last submitted patch failed testing.

#8

Posted by Xano on August 12, 2009 at 2:38pm
Status:needs work» needs review

Fixed the bug and integrated the patch with #510782: Installer links to help module and other pages even when they are not available.

AttachmentSizeStatusTest resultOperations
node_decouple_system_08.patch19.07 KBIdleFailed: Failed to apply patch.View details | Re-test

#9

Posted by System Message on August 14, 2009 at 3:05pm
Status:needs review» needs work

The last submitted patch failed testing.

#10

Posted by eaton on August 19, 2009 at 5:56pm

#11

Posted by joshmiller on October 21, 2009 at 6:40pm
Version:7.x-dev» 8.x-dev

Definitely a D8 idea...

#12

Posted by chx on February 27, 2010 at 9:53pm

http://buytaert.net/8-steps-for-drupal-8 let's stop saying smallcore.

nobody click here