started cleaning up a bit but don't have time right now so submitting what i have. Regarding function webfm_inline_js, looking at http://api.drupal.org/api/function/drupal_to_js i don't think drupal_to_js on paths is necessary at all, also the function should not return anything and declare the variables global instead of parameters..

CommentFileSizeAuthor
webfm-php-warnings.patch6.79 KBeMPee584

Comments

robmilne’s picture

robmilne commented

Hey, thanks for improving the module. I don't have any php dev tools - only firebug for the js side of things.

robmilne’s picture

robmilne commented

Slight change needed to webfm_inline_js - the default behaviour (single arg) is to regard the data as a 'module' - see http://api.drupal.org/api/function/drupal_add_js/6:

drupal_add_js($js, 'inline');
robmilne’s picture

robmilne commented
Status: Needs work » Fixed

in head

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.