Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
Hi, i have developed couple of websites using Drupal. The most recent install that i did involved taking a free theme from Drupal directory of themes. But since my client didn't like exactly like it was i had to change it here and there. The bottom line is i now have a modified theme that looks much different and i would like to contribute it for public use.
You could see a demo site @ http://frumall.ca/drupal
And the screenshot @ http://frumall.ca/drupal/sites/all/themes/energetic/screenshot.png
I'm also working on a few simple modules. One of them being to display random slogan. I found a solution by editing the page.tpl.php file but i am working on making that into module where you could change the slogans from the backend.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Energetic Remake Red.tar_.gz | 447.02 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commentedI hope i did everything right i tried folowing the documentation on drupal.org. If i did make some mistakes please let me know.
Comment #2
AjK commentedWe need to see samples of code, either theme or modules. Not demos.
Comment #3
Anonymous (not verified) commentedplease review the attached theme. Thanks (I thought i attached it the first time :) )
Comment #4
ultimateboy commentedThere are several issues I have with this particular contribution. To begin, the theme does not show "ingenuity and originality by the author" (#539608). As stated in the footer, this theme is simply a remake of http://drupal.org/project/energetic and therefore does not show that *you* have enough knowledge of the Drupal API or security best practices and I cannot gain that information from your track record either.
Also, the HTML itself is not up to the quality that I like to see with newly created themes. There are also quite a few issues with the PHP in the template.php file of not following coding standards or name spacing issues, and frankly there is some stuff that really should not be in themes without a more defined purpose, or at least well defined comments. There is also a lot of javacript that I really dont think is necessary for this basic of a theme.
Feel free to ask specific questions about any of the points I have made above and I will clarify if need be, but for the time being, I am going to deny this application. You can re-apply at any time taking into account some of the items I have mentioned.