Hi,

I have community tags set up as a block. When I have 'Block cache' enabled the community tags form starts to show bugs. On first loading of a page it displays fine, but on reloading it fails to fill the tags correctly, they appear in the block input text box as a comma separated list.

Has anyone else experienced this problem? Is there a solution?

Bill

Comments

yngens’s picture

I confirm this behavior. Couldn't find any solution other than disabling block cache.

TimelessDomain’s picture

Title: problem with block caching » block caching breaks functionality

when the community tags form is in a block, with block caching enabled, submitted tags are saved to the wrong node.

Is it possible to disable block caching for the Community Tags block by default? (that way we can keep block caching on while maintaining full functionality of this module) - thanks

asb’s picture

Priority: Normal » Major

Same problem, damn!

This is a real showstopper - who can afford to run a Drupal site without black caching?

entrigan’s picture

I agree, this is a major bug. I am not sure why this is happening, does it seem like a problem with the AJAX?

entrigan’s picture

Just realized the obvious here: The block changes per node and per user so the only caching schemes that will work are either no cache or
'cache' => BLOCK_CACHE_PER_USER | BLOCK_CACHE_PER_PAGE,

One of these changes will make it into the next release.

asb’s picture

> One of these changes will make it into the next release.

Would this be the 1.x or the 2.x branch of 'Community Tags', or is this a Core issue?

Has someone already tried Block Cache Alter? Does it help?

entrigan’s picture

It will certainly go into 1.x. Not sure what is going to happen with 2.x yet.

Block Cache Alter module should work. Just set the block to not cache.

TimelessDomain’s picture

Status: Active » Needs review

#6 Testing: using 1.x -> installed block cache alter -> set the community tags block cache settings to do not cache.
#6 Results: IT WORKS for anonymous & logged in users now!
THANKS for the suggestion ASC

entrigan’s picture

@TDomain Thanks for reporting back, is there a per user per page option in block cache alter?

TimelessDomain’s picture

@Entrigan - Thanks for maintaining this module. Yes, there is a "per user per page" option in block cache alter. Just tested it & it seems to be working correctly with Community Tags block (anonymous & authenticated).
It may be better to not cache at all though, since "per user per page" may reduce performance -> because each user is likely to visit each page only once (most sites) & having it store this in the cache would be a waste of space/ processing power (since the cache would never be utilized).

entrigan’s picture

Ya, I agree no cache is probably the best default. We can then either have a setting for changing it to "per user per page" or just recommend those who need that level of caching use block cache alter module.

I expect to roll a new dev release on Tuesday. Thanks!

asb’s picture

@TDomain: Have you applied one of the core patches provided by Block Cache Alter, or does this work without them anyway? Since I'm using Pressflow on most of my sites I havn't tried this yet because of those patches...

TimelessDomain’s picture

it works fine without the Block Cache Alter core patch. i applied the Block Cache Alter core patch, and this worked as well (for community tags at least). But decided to remove the patch after it messed up some other modules. (i am also using pressflow)

chaps2’s picture

Category: support » bug

The ctag block is not compatible with block caching at the moment.

The main reason is that the ctag JS settings are not written to the page if the block is cached (see community_tags_node_view()). This explains the comma separated tags in the textfield. It should be possible to re-write this to work but as this is actually a bug I'll set the block to "no cache" and put a note in the README.txt.

chaps2’s picture

Status: Needs review » Fixed

Community tags block cache has been disabled in 1.x and 2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chaps2’s picture

Title: block caching breaks functionality » Support block caching
Version: 6.x-1.x-dev » 6.x-2.x-dev
Component: User interface » Code
Category: bug » feature
Status: Closed (fixed) » Fixed

Changing this to a feature request for CT 2.x and renaming accordingly.

This is now in.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.