Active
Project:
Signup
Version:
6.x-1.0-rc4
Component:
Email
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Aug 2009 at 23:03 UTC
Updated:
1 Sep 2009 at 07:10 UTC
The field for a default confirmation/reminder message now comes with a pre-filled default of "Enter your default confirmation/reminder email message here". This line is retrieved from the DB, where its default form is loaded at install time. (function signup_insert_default_signup_info() This leads to the text being invisible to translation functionality.
Comments
Comment #1
ioskevich commentedSubscribing. Does anyone know how to make default confirmation/reminder message translatable? Is there any place where I can hook in Signup module and make it load translated default text without hacking module's code?
Comment #2
dwwNo, it's just a bug that it loads in the defaults directly to the DB without t(). However, I doubt just wrapping that in t() is going to actually make this work right -- it's just going to be loaded into the DB using the active language during the time the module is installed. Furthermore, none of the customized templates are translatable. The whole way this module handles email is a mess and done wrong -- one of the things I haven't re-written (yet) since I took over the module. See #290305: Split out email functionality into separate submodule(s). I'm tempted to just postpone this bug in favor of that. However, if someone thought t() around the text when the module is first installed (and when you click on the "Reset to defaults" button on the admin settings page) would help, that's a pretty small patch and I'd put that in before RC5.
Comment #3
markus_petrux commentedI think this could be addressed if record for nid 0 in {signup} table was migrated to use Drupal variables. That way we could Multilingual Variables to make these texts translatable.
For reference:
- #564734: Multi-language support for email templates in OG Settings / Messaging & Notifications (covers OG related mails).
- #563048: Multilanguage support for user emails using i18n (would cover how to for user related mails).