I just got several headakes when upgrading from panels 2 to 3 since the node view override didnt work anymore. Many hours later I figured it out by reading a post on another comment override module where panels 3 seemed to break.
So, if you're using Comment display AND Panels 3 together in some fashion - just change these lines in comment_display.module from:
function comment_display_menu_alter(&$callbacks) {
$callbacks['node/%node']['page callback'] = 'comment_display_node_page_view';
$callbacks['node/%node/revisions/%/view']['page callback'] = 'comment_display_node_show';
}
to:
function comment_display_menu_alter(&$callbacks) {
if (!module_exists('page_manager') && $items['node/%node']['page callback'] == 'node_page_view') {
$callbacks['node/%node']['page callback'] = 'comment_display_node_page_view';
$callbacks['node/%node/revisions/%/view']['page callback'] = 'comment_display_node_show';
}
}
PS. Yeah, I should've made a patch but hey I should be sleeping allready. Sorry.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | comment_display.module.546616.patch | 1.04 KB | mr.j |
Comments
Comment #1
sunThanks! However, that is already fixed in the latest development snapshot.
Comment #3
jcisio commentedI used the 1.0 with Panels 3 and node/%node breaks. Remove the module, but that doesn't fix. Cache cleared. Any idea?
Thanks.
Comment #4
jcisio commentedComment #5
jcisio commentedDon't bother. I got it. Just go to Panels page and re-enable the node/%node page, it will work again.
Comment #6
sunNot sure what I was smoking in #1, but I committed that Panels fix now.
Comment #8
mr.j commentedI hate to drag up such an old issue but this was never fixed properly.
We use page manager but only for the home page on our site and we don't use it to override any node templates. So what happens without the correct fix is that all comments on a node are printed twice: first using the template variable that this module adds, then the default comments from the node module which are never removed because the page callback is never overridden.
Comment #9
mr.j commentedThis fix works as it overrides the callback if the default one is still in place irrespective of what modules are installed, which is more or less what page_manager does itself.
Comment #10
sunPatch doesn't apply.