Disable "My Classified Ads list" menu tab when users who can't create ads view own profile

Fixed in -dev. Will be in next release. Users will only see a "My Classified Ads List" if they have permission to create, edit, or reset ads.

Cheers,

Miles

@drupup: Just pull down the alpha6 release, the modification is included in that. All I've done is surround the user hook with a check to see what permissions they have. Very simple change. You need to be sure to flush your cache though.

I'm no longer considering any merge with the Advertisement module, the modules aren't on a convergent path at this time. I took over as maintainer of the Views module for Advertisement to start to see how it ticks and realised that they're chalk and cheese. I've been short of time the last few months but am keen to make a big push soon on new features for ed_classified and get it into Beta.

Cheers,

Miles

!!! I'll have a look at it. Reopening.

Cheers,

Miles

I have this issue too

#5 worked for me

Issue also exists in 6.3.

Some sites may want the access check has to be a bit more involved than just checking a permission: a user may have the permission and have created ads, then have the permission removed before his ads were removed. In that case, some sites might allow the user to still have access to the ads he created previously, although the user whould have no right to create new ads.

The permission scheme has more levels now (create, delete any/own, edit any/own, reset). How about these rules ?

• permission to create: show tab, ads list, link to ad creation
• no permission to create:
  • no existing ads: hide tab, or show tab and a "teasing" message on page telling him to gain the perm ?)
  • existing ads: show tab, ads list, and the "teasing" message

This would involve additional settings:

• a choice of whether to hide or show the page to users without create perm and no ads
• a customizable "teasing" message, likely with Token integration

In the meantime, I have added a Simpletest catching that error, so tests won't pass until this is fixed one way or another.

Also note suggestion by cousin_itt for access control on duplicate issue http://drupal.org/node/959434#comment-4296696

Rethought about this question. IMO, the most logical choice is to enable this tab whenever user has the permission to see ads, whether or not there are ads on his account.

If they do not have permission to create ads, it could be a good place to add some text inviting them to gain access to ads creation, like a link to purchase the role giving them access. Seems more useful than just hiding the feature.

I would i like to know how to hide the Ads tab in user account. Since the user is not permitted to post any ads.

I attached a picture of the unwanted tab "Ads"
thanks and regards

I do not think this is a good idea, and will therefore not include it in the module itself. IMO the better idea is to leave that tab available and include some call to action on the target page to gain access to the ads functionality (for example purchase a premium role on the site). For the reasons explained above in this thread, just hiding the tab when a user does not have permission to create ads is not as simple as it may seem.

This said, if you want to do it although the module itself does not follow that logic, you can implement hook_menu_alter() in your module, to modify the menu entry for "user/%user/classified", and change the access callback/access arguments to apply whatever policy you wish, in your case probably somehow like this:

function mymodule_menu_alter(&$items) {
  $items['user/%user/classified']['access callback'] = 'user_access';
  $items['user/%user/classified']['access arguments'] = array('create classified content');
}