Posted by NancyDru on August 12, 2009 at 9:53pm
Jump to:
| Project: | Revision Deletion |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The attached patch brings the 5.x version (will be ported to 6.x shortly) to compliance with the coding standards.
In addition, it makes, IMHO, the admin interface much cleaner (must clear the menu cache) by using radios and checkboxes (hence added a css file). I altered the intervals a bit. There were several strings that were not translatable so I wrapped them in t(). I added some descriptive text to the list.
One should not, as a friend recently discovered, allow a module like this to fire its cron code before the adopter is fully aware of what they're doing. So I set the default cron interval to 0, for "manual only" and added code to check for that.
| Attachment | Size |
|---|---|
| revision_deletion.css_.txt | 695 bytes |
| revision_deletion_5_01.patch | 10.94 KB |
Comments
#1
#2
These look great, NancyDru. I admit I have neglected this module since the site that prompted its creation is no longer in use.
Thanks. -Greg
#3
No problem.
#4
Included in the -rc1 versions.