Posted by Thomas_Zahreddin on August 13, 2009 at 9:19am
6 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | user interface text |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (works as designed) |
| Issue tags: | D8MI |
Issue Summary
update.php includes many strings, that can't be translated.
(I just want to file this, maybe i find the time to post a patch later)
Comments
#1
sorry, typo in subject
#2
Moving to user interface text component.
#3
#4
you got me …
:-)
#5
Yes, well, the reason it does not use any translation function is that update.php is the place where the schema might change for localization. Theoretically we can ensure that any locale updates run before everything else, but that sounds like a policy change.
#6
The last submitted patch, translate_update-548038-4.patch, failed testing.
#7
Re-roll patch from #4 to fix syntax errors and be more in line with making links translatable and keeping block level elements out of t().
@Gábor Hojtsy, does that mean that we should not try to make any of the strings in update.php translatable?
#8
Well, the goal of update.php is to run changes on the Drupal database while using as minimal a subset of Drupal features as possible. Running updates on locale module related tables, caches, settings, etc. are one of the possibilities. If we use the locale subsystem in the update, we make this impossible or at least pretty hard.
#9
In other words, we should probably look more for avoiding calling t() and not invoking t() in the update system I think. (Even though the update bootstrap prepare code can theoretically set up a t() friendly environment). Are we using t() at some places already in update that makes it look like we should use it everywhere?
#10
#11