update.php includes many strings, that can't be translated.

(I just want to file this, maybe i find the time to post a patch later)

Comments

Thomas_Zahreddin’s picture

Title: untralatable text in update.php » untraslatable text in update.php

sorry, typo in subject

webchick’s picture

Component: base system » user interface text

Moving to user interface text component.

yoroy’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +D8MI
Thomas_Zahreddin’s picture

StatusFileSize
new12.83 KB

you got me …

:-)

gábor hojtsy’s picture

Status: Active » Needs review

Yes, well, the reason it does not use any translation function is that update.php is the place where the schema might change for localization. Theoretically we can ensure that any locale updates run before everything else, but that sounds like a policy change.

Status: Needs review » Needs work

The last submitted patch, translate_update-548038-4.patch, failed testing.

drupal_was_my_past’s picture

Status: Needs work » Needs review
StatusFileSize
new14.07 KB

Re-roll patch from #4 to fix syntax errors and be more in line with making links translatable and keeping block level elements out of t().

@Gábor Hojtsy, does that mean that we should not try to make any of the strings in update.php translatable?

gábor hojtsy’s picture

Well, the goal of update.php is to run changes on the Drupal database while using as minimal a subset of Drupal features as possible. Running updates on locale module related tables, caches, settings, etc. are one of the possibilities. If we use the locale subsystem in the update, we make this impossible or at least pretty hard.

gábor hojtsy’s picture

Status: Needs review » Needs work

In other words, we should probably look more for avoiding calling t() and not invoking t() in the update system I think. (Even though the update bootstrap prepare code can theoretically set up a t() friendly environment). Are we using t() at some places already in update that makes it look like we should use it everywhere?

artusamak’s picture

Title: untraslatable text in update.php » Untranslatable text in update.php
gábor hojtsy’s picture

Status: Needs work » Closed (works as designed)