Wow, first issue in the queue! Firstly, this is a handy little module, so thanks a lot.

When you set a correct path for the ScrollTo plugin in the settings form, you may still recieve the error:

"The Inline Messages module requires the jQuery ScrollTo plugin to work"

This is because the module is always looking at the default path and isn't looking in the new location you've just set.

I've included a patch to fix this, taken against CVS HEAD.

CommentFileSizeAuthor
inline_messages_path.patch1.23 KBjohngriffin

Comments

Phil Wolstenholme’s picture

Phil Wolstenholme commented

This got me too, I'm not sure how to patch so I'll wait until this makes it into a release.

andrewmacpherson’s picture

andrewmacpherson commented
Status: Patch (to be ported) » Reviewed & tested by the community

I've tested the patch - it works.

andrewmacpherson’s picture

andrewmacpherson commented

Note that the issue only concerns the admin settings page for the Inline Messages module.

The only problem is getting an incorrect error message on the settings page, when the jquery.scrollTo.js file is correctly installed at the path specified.

The module does behave as expected, e.g. when submitting a comment without the required comment body.

andrewmacpherson’s picture

andrewmacpherson commented

This also affects the inline errors module.
#572846: jQuery ScrollTo plugin path not being recognised in Inline Errors module

andrewmacpherson’s picture

andrewmacpherson commented
Title: jQuery ScrollTo plugin path not being recognised » jQuery ScrollTo plugin path not being recognised by Inline Messages
john.kenney’s picture

john.kenney commented

installed patch and it worked for me. thank you!

jsfwd’s picture

jsfwd commented

Thanks for finding the bug... the issue is fixed with 6.x-1.4

@andrewmacpherson Inline Messages has replaced Inline Errors so there will be no fixes to that module.

andrewmacpherson’s picture

andrewmacpherson commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.