Posted by dropcube on August 13, 2009 at 2:28pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | filter.module |
| Category: | task |
| Priority: | normal |
| Assigned: | dropcube |
| Status: | closed (fixed) |
Issue Summary
Remove hook_filter_tips in favor of a 'tips callback' provided by a info hooks for filters.
Related issues:
#546336: hook_filter_info(): Remove $op from hook_filter()
#546350: Remove hardcoded numeric deltas from hook_filter_info()
Comments
#1
I am marking this critical, as this is an API change we should get in before the code freeze.
#2
This patch removes
hook_filter_tipsimplementations from core and includes the filter tips in callback functions, declared inhook_filter_info()with"tips callback"key.#3
Please justify your patch and your priority. "becuase we are near freeze" is not a justifcation.
#4
@moshe: This is a follow up of #546336: hook_filter_info(): Remove $op from hook_filter() (already in core), which introduces a registry-style info hook for filters. With
'tips callback', we do not needhook_filter_tipsany more. So, as this is an API change, I think it's critical to get some of this in before the freeze.#5
#6
This is a required follow-up of the filter refactoring. Committed!
Marking 'needs work' because we need to update the upgrade instructions in the handbook. Mark 'fixed' after the documentation is in place.
Thanks dropcube.
#7
In the future, please use render() arrays arrays instead of strings. This delays theming until after the page is fully built. As written here, the 'Character Description' table and all the rest is baked in.
#8
Tagging.
#9
The module upgrade guide for this definitely needs some work, but I think it is more appropriately discussed on #546336: hook_filter_info(): Remove $op from hook_filter(), because changes to doc from that update need to be made before this one can even be addressed. So I'll add a comment there.
#10
Added upgrade instructions: hook_filter() replaced by hook_filter_info(), and removed hook_filter_tips()
#11
Automatically closed -- issue fixed for 2 weeks with no activity.