Remove hook_filter_tips()

dropcube - August 13, 2009 - 14:28
Project:Drupal
Version:7.x-dev
Component:filter.module
Category:task
Priority:normal
Assigned:dropcube
Status:closed
Description

Remove hook_filter_tips in favor of a 'tips callback' provided by a info hooks for filters.

Related issues:
#546336: hook_filter_info(): Remove $op from hook_filter()
#546350: Remove hardcoded numeric deltas from hook_filter_info()

#1

dropcube - August 13, 2009 - 20:47
Priority:normal» critical
Status:postponed» active

I am marking this critical, as this is an API change we should get in before the code freeze.

#2

dropcube - August 13, 2009 - 21:27
Status:active» needs review

This patch removes hook_filter_tips implementations from core and includes the filter tips in callback functions, declared in hook_filter_info() with "tips callback" key.

AttachmentSizeStatusTest resultOperations
remove-hook_filter_tips.patch23.6 KBIdlePassed: 12115 passes, 0 fails, 0 exceptionsView details | Re-test

#3

moshe weitzman - August 13, 2009 - 23:53
Priority:critical» normal

Please justify your patch and your priority. "becuase we are near freeze" is not a justifcation.

#4

dropcube - August 14, 2009 - 00:07

@moshe: This is a follow up of #546336: hook_filter_info(): Remove $op from hook_filter() (already in core), which introduces a registry-style info hook for filters. With 'tips callback', we do not need hook_filter_tips any more. So, as this is an API change, I think it's critical to get some of this in before the freeze.

#5

dropcube - August 14, 2009 - 00:09
Priority:normal» critical

#6

Dries - August 14, 2009 - 08:07
Priority:critical» normal
Status:needs review» needs work

This is a required follow-up of the filter refactoring. Committed!

Marking 'needs work' because we need to update the upgrade instructions in the handbook. Mark 'fixed' after the documentation is in place.

Thanks dropcube.

#7

moshe weitzman - August 14, 2009 - 12:47

In the future, please use render() arrays arrays instead of strings. This delays theming until after the page is fully built. As written here, the 'Character Description' table and all the rest is baked in.

#8

webchick - August 14, 2009 - 14:52

Tagging.

#9

jhodgdon - August 14, 2009 - 17:13

The module upgrade guide for this definitely needs some work, but I think it is more appropriately discussed on #546336: hook_filter_info(): Remove $op from hook_filter(), because changes to doc from that update need to be made before this one can even be addressed. So I'll add a comment there.

#10

dropcube - August 21, 2009 - 05:23
Status:needs work» fixed

Added upgrade instructions: hook_filter() replaced by hook_filter_info(), and removed hook_filter_tips()

#11

System Message - September 4, 2009 - 05:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.