The first example in the Forms API Quick Start Guide at
http://drupaldocs.org/api/head/file/contributions/docs/developer/topics/...

includes this line: #default_value' => $edit['foo'],

but according to chx, it is better practice to use #default_value' => 'foo', instead. The suggested patch fixes this example.

As this is one of the very first examples developers on the learning will read about 4.7, it seems important to make sure the code matches best current practices.

CommentFileSizeAuthor
forms_api.html.patch1.89 KBfgm

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Hm. Really? $edit['foo'] and 'foo' are not the same thing. One is saying "The $foo variable that was submitted with the form" the other is saying "Make it literally the word 'foo'."

I'll talk to chx about this next time I see him to see if he can clarify this.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I talked to chx about this the other day... the deal is we need to remove references to obtaining $edit via $_POST['edit'], not change the actual #default_value thing. Unfortunately this is not as simple as just erasing all instances of $_POST['edit']; it requires re-writing some of the text.

anschinsan’s picture

anschinsan commented
Project: Documentation » Drupal core
Version: » 7.x-dev
Component: Developer Guide » documentation
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Closed (won't fix)

fixed yonks ago.