like it says, add support for the views module. it'd let people roll their own table views very easily.

CommentFileSizeAuthor
#10 views_audio.inc4.46 KBdrewish
#9 views_audio.inc_0.txt3.18 KBdrewish
#8 audio.module_54881_views_1.patch609 bytesdrewish
#6 audio.module_54881_views_0.patch10.11 KBdrewish
#4 views_audio.inc.txt2.84 KBdrewish
#3 audio.module_54881_views.patch607 bytesdrewish

Comments

drewish’s picture

drewish commented
Assigned: Unassigned » drewish

looks like bryght is going to sponsor this. i'll be sitting on a plane to new your tomorrow so i'll have some time to work on this.

i'm just looking forward to being able to have a "most popular audio" block.

drewish’s picture

drewish commented

that should have read "to new york tomorrow"...

drewish’s picture

drewish commented
Status: Active » Needs work
StatusFileSize
new audio.module_54881_views.patch607 bytes

here's a patch to the audio module to have it load a views_audio.inc file.

i would think that i'll probably be posting multiple versions of the views_audio.inc file, but this should be the only patch needed against the audio module itself.

drewish’s picture

drewish commented
StatusFileSize
new views_audio.inc.txt2.84 KB

this is a really basic implementation of the views hooks. mostly just to prove that i'm working on it. it doesn't link in the meta data yet.

drewish’s picture

drewish commented

eaton and merlinofchaos, convinced me that the views support would work a lot better if the tag settings were in a table rather than stuffed into an array. the attached patch ads a new audio_settings table and migrates the settings into it. i'll probably need to add some caching to audio_get_tag_settings()...

i'll work on the views support more tomorrow.

drewish’s picture

drewish commented
StatusFileSize
new audio.module_54881_views_0.patch10.11 KB
moshe weitzman’s picture

moshe weitzman commented

drewish - any update on this? client is starting to itch ...

drewish’s picture

drewish commented
StatusFileSize
new audio.module_54881_views_1.patch609 bytes

sorry for the lack of progress on this moshe. i was hoping you could provide a bit more info on what your client is trying to do exactly. i've gotten more stuff working but if you've got priorities that would help direct the development.

i decided to step back from moving the tags settings into a table. i don't think it's necessary for the views support, i may consider it at some other point though.

drewish’s picture

drewish commented
StatusFileSize
new views_audio.inc_0.txt3.18 KB

here's the updated views file. all tags are now exposed. i'm not sure how efficient it is but it looks like it does the job.

drewish’s picture

drewish commented
StatusFileSize
new views_audio.inc4.46 KB

added id3tag filters, and link to download or play the file.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Reviewed & tested by the community

I tested the latest patch and include file. Works well.

drewish’s picture

drewish commented
Status: Reviewed & tested by the community » Fixed

Thanks, this has been committed to HEAD.

moshe weitzman’s picture

moshe weitzman commented
Status: Fixed » Active

i think Views added a function that you use:

PHP Fatal error: Cannot redeclare views_handler_field_filesize() (previously declared in /Library/WebServer/contributions/modules/audio/views_audio.inc:147) in /Library/WebServer/contributions/modules/views/views.module on line 1650

drewish’s picture

drewish commented

yeah, it's already been removed from CVS. you should go ahead and at least update views_audio.inc

drewish’s picture

drewish commented
Status: Active » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)