Whenever feedapi_mapper_delete_mapping() is executed on a default mapping (e. g. in feedapi_mapper_toggle_unique() or in feedapi_mapper_default_form_submit() ) it will break.

Comments

aron novak’s picture

Status: Active » Needs review
StatusFileSize
new1.34 KB

The delete function now overrides the mapping first if it was asked to delete from code.

alex_b’s picture

Status: Needs review » Needs work

Let's encapsulate this functionality in a

feedapi_mapper_override(...) function.

We can call this function from anywhere where we would want to change an existing mapping. The function should just have no effect if applied on a mapping that is overridden or normal.

aron novak’s picture

Status: Needs work » Needs review
StatusFileSize
new2.43 KB

Yeah, makes sense.

aron novak’s picture

Status: Needs review » Fixed

Committed in order to be able to produce sane patches for #548850: Toggle unique broken. Anyway these changes were tested.

aron novak’s picture

Status: Fixed » Closed (fixed)