Whenever feedapi_mapper_delete_mapping() is executed on a default mapping (e. g. in feedapi_mapper_toggle_unique() or in feedapi_mapper_default_form_submit() ) it will break.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 548852-3_delete_mapping_from_code.patch | 2.43 KB | aron novak |
| #1 | 548852_delete_mapping_from_code.patch | 1.34 KB | aron novak |
Comments
Comment #1
aron novakThe delete function now overrides the mapping first if it was asked to delete from code.
Comment #2
alex_b commentedLet's encapsulate this functionality in a
feedapi_mapper_override(...) function.
We can call this function from anywhere where we would want to change an existing mapping. The function should just have no effect if applied on a mapping that is overridden or normal.
Comment #3
aron novakYeah, makes sense.
Comment #4
aron novakCommitted in order to be able to produce sane patches for #548850: Toggle unique broken. Anyway these changes were tested.
Comment #5
aron novak