Download & Extend

Uploading tricky filenames leads to 404

Project:Drupal core
Version:7.x-dev
Component:file system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (duplicate)

Issue Summary

Let's say you have a file named "watch?v=6bzggUe3tsc.txt"
Upload, attach it to a node (use Firefox, Opera removes the nasty parts of the filename!), and the Attachment section will contain a link that leads to 404. The filenames may also contain URL-stopper parts. I'd propose to add urlencode to make sure everything will be smooth.

AttachmentSizeStatusTest resultOperations
fix_tricky_filename.patch824 bytesIdleFailed: 12083 passes, 3 fails, 0 exceptionsView details | Re-test

Comments

#1

Also, this one exists also in Drupal 6.x of course.
I used Firefox/2.0.0.14 to upload the file from my local system.

#2

Status:needs review» needs work

The last submitted patch failed testing.

#3

Status:needs work» needs review

Yeah, only alter the filename part.

AttachmentSizeStatusTest resultOperations
549162-3_fix_tricky_filename.patch910 bytesIdlePassed: 12144 passes, 0 fails, 0 exceptionsView details | Re-test

#4

This is also covered by the patch for #284899: Drupal url problem with clean urls.

#5

c960657: good, I will review #284899: Drupal url problem with clean urls and make that RTBC if this looks good.

#6

Status:needs review» closed (duplicate)

cool lets mark this as a duplicate then.

nobody click here