the values returned by userreference_user hook are incorrectly formated, resulting in garbage output on user/'uid' and user/'uid'/edit pages.

The included patch corrects that
Note : it doesn't deal with the content of the 'referenced by' secondary tab on the user edit page, which is still empty for the moment ($op == 'form' not implemented)

CommentFileSizeAuthor
#2 userreference.module_0.patch1.29 KByched
userreference.module.patch1.49 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
yched’s picture

yched commented
StatusFileSize
new userreference.module_0.patch1.29 KB

Updated :
$field['field_name'] is not available in this part of the code - and maybe not relevant either ?

codexmas’s picture

codexmas commented

I described this issue in another comment:
http://drupal.org/node/53429

It is not really a bug because several of the CCK modules are under development.
Especially the userreference module, it is basically just a skeleton that hasn't been
fleshed out yet.

yched’s picture

yched commented

Agreed on the 'skeleton' thing.
Yet the _user hook generating the display on user profile pages is coded, it's just not outputting the results in the expected format.

So even if the code is subject to future changes, we might just as well put a coherent version in cvs..

jonbob’s picture

jonbob commented

This feature has been removed temporarily, but I'll leave this issue in patch status for when I have time to review the fix and reintroduce the feature. It needs to be done in a somewhat configurable fashion, I think; the presence of userreference should not enforce this display. Maybe it's not the domain of this module at all.

jonbob’s picture

jonbob commented
Status: Needs review » Fixed

The status of the related feature request is now handled at http://drupal.org/node/60713.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)