user_profile_form_validate() is not called when submitting user/1/edit (user_profile_form).
Only user_validate_picture() is run.

This notably skips Field API validation.

CommentFileSizeAuthor
#7 validate_profile_549726_v2.patch500 bytesJuliaKM
#3 validate_profile_549726.patch514 bytesJuliaKM

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Fields in Core, +Novice

Oh yes please. Let's fix this because I keep mistakenly thinking that fields aren't working when it's just users.

Based on yched's description, this sounds like a one-liner, so tentatively marking as a Novice patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Ok, I don't have time to roll a patch, but the change should be simple:

in user_edit_form, we add "$form['#validate'][] = 'user_validate_picture';". Because there is now a #validate function defined, the default $form_id_validate is not used anymore and needs to be added manually.

To fix this, just add "$form['#validate'][] = 'user_profile_form_validate';" in user_profile_form(). Also, a test would be great...

JuliaKM’s picture

JuliaKM commented
Status: Needs review » Active
StatusFileSize
new validate_profile_549726.patch514 bytes

Here's a first stab at a patch. This patch doesn't include a test because I wasn't sure what the test needs to do.

JuliaKM’s picture

JuliaKM commented
Status: Active » Needs review

Status: Active » Needs work

The last submitted patch failed testing.

JuliaKM’s picture

JuliaKM commented
Status: Needs work » Needs review
StatusFileSize
new validate_profile_549726_v2.patch500 bytes

Please ignore the previous patch. Here's a new version that still needs a test.

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review

Oh, testing bot...

Status: Needs review » Needs work

The last submitted patch failed testing.

mfb’s picture

mfb
they or he
commented
Status: Needs work » Closed (duplicate)

Duplicate of #239676: SA-CORE-2009-001: Missing validation for hook_user

usaroch’s picture

usaroch commented
Title: user_profile_form_validate() not called when submitting user_profile_form » i want to add terms of use and validations to registeration form
Version: 7.x-dev » 6.7
Assigned: Unassigned » usaroch
Category: bug » task
Status: Closed (duplicate) » Active

hi

i want to add terms of use and validations to registration form. its urgent can i one help me.

regards udit saroch

yched’s picture

yched commented
Title: i want to add terms of use and validations to registeration form » user_profile_form_validate() not called when submitting user_profile_form
Version: 6.7 » 7.x-dev
Assigned: usaroch » Unassigned
Category: task » bug
Status: Active » Closed (duplicate)

Please don't reopen issues fixed and closed 1 year ago for a semi related feature request on a different core version. This is issue hijacking and confuses the hell out of everyone. This is not how the issue queue works. Please open a new issue instead.

+ assigning an issue to yourself means that you intend to work on resolving it yourself.