Steps to reproduce:

use cvs everything:
install drupal
install flexinode
install event
install eventrepeat
get cron running
create a content type with some text areas
enable eventrepeat and event for content type
create a node of that content type that is a repeat event.
attempt to create another node of that type, or edit that node, and all javascript is wack.

CommentFileSizeAuthor
#5 event_all_day.patch814 bytesjoelstein

Comments

port’s picture

port commented

Description

Steps to reproduce:

use cvs everything:
install drupal
install flexinode
install event
install eventrepeat
get cron running
create a content type with some text areas
enable eventrepeat and event for content type
create a node of that content type that is a repeat event.
attempt to create another node of that type, or edit that node, and all the javascript is broken.

On further review, this appears to be a conflict with the event_all_day module.

hunmonk’s picture

hunmonk commented
Priority: Critical » Normal
hunmonk’s picture

hunmonk commented
Title: eventrepeat w/ flexinode content type breaks javascript » event_all_day w/ flexinode content type breaks javascript
Project: Event Repeat » Event
Version: master » 4.6.x-1.x-dev
Priority: Normal » Critical

upon further testing, i don't think eventrepeat is involved at all--looks like it's the js in event_all_day that's doing it. moving this issue to the event issue queue

hunmonk’s picture

hunmonk commented
Version: 4.6.x-1.x-dev » 5.x-2.x-dev
joelstein’s picture

joelstein commented
Title: event_all_day w/ flexinode content type breaks javascript » event_all_day breaks javascript
Status: Active » Needs review
StatusFileSize
new event_all_day.patch814 bytes

This issue happens with or without flexinode. I duplicated it with a fresh HEAD and with the basicevent module. Here's a patch which fixes the javascript error. It appears that the checkbox wasn't really getting into the form via _form_alter when appended to $form['event_start']['date'], but when put in $form, it works just fine.

A related issue: the event_all_day module only works if you are using 24 hour mode. In 12 hour mode, it doesn't set the am/pm appropriately. Since many people use 12 hour mode, I think this also needs fixing.

solutiondrop’s picture

solutiondrop commented

joelstein, I've used your patch for the last few days. Thanks!
It does the job. +1 for this.

killes@www.drop.org’s picture

killes@www.drop.org commented
Component: Code » Event All Day

Moshe, that's your's.

jjeff’s picture

jjeff commented
Status: Needs review » Reviewed & tested by the community

Works for me! event_all_day was breaking all of the expandable regions on the page. Installed patch. Things are working again.

+1

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Fixed

committed. thanks ... please open new issue for 24 hour bug (and provide a patch if possible). im not working on this one actively.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)