event_all_day breaks javascript
port - March 20, 2006 - 19:16
| Project: | Event |
| Version: | 5.x-2.x-dev |
| Component: | Event All Day |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
Steps to reproduce:
use cvs everything:
install drupal
install flexinode
install event
install eventrepeat
get cron running
create a content type with some text areas
enable eventrepeat and event for content type
create a node of that content type that is a repeat event.
attempt to create another node of that type, or edit that node, and all javascript is wack.
#1
Description
Steps to reproduce:
use cvs everything:
install drupal
install flexinode
install event
install eventrepeat
get cron running
create a content type with some text areas
enable eventrepeat and event for content type
create a node of that content type that is a repeat event.
attempt to create another node of that type, or edit that node, and all the javascript is broken.
On further review, this appears to be a conflict with the event_all_day module.
#2
#3
upon further testing, i don't think eventrepeat is involved at all--looks like it's the js in event_all_day that's doing it. moving this issue to the event issue queue
#4
#5
This issue happens with or without flexinode. I duplicated it with a fresh HEAD and with the basicevent module. Here's a patch which fixes the javascript error. It appears that the checkbox wasn't really getting into the form via _form_alter when appended to $form['event_start']['date'], but when put in $form, it works just fine.
A related issue: the event_all_day module only works if you are using 24 hour mode. In 12 hour mode, it doesn't set the am/pm appropriately. Since many people use 12 hour mode, I think this also needs fixing.
#6
joelstein, I've used your patch for the last few days. Thanks!
It does the job. +1 for this.
#7
Moshe, that's your's.
#8
Works for me! event_all_day was breaking all of the expandable regions on the page. Installed patch. Things are working again.
+1
#9
committed. thanks ... please open new issue for 24 hour bug (and provide a patch if possible). im not working on this one actively.
#10