#543608: path.module creates additional alias instead of modifying existing, after node preview isn't tested by simpletest in path.test

CommentFileSizeAuthor
#26 path-alias-preview-test-550258-26.patch2.29 KBmgifford
#23 path-alias-preview-test-550258-23.patch1.38 KBvalthebald
#20 path-alias-preview-test-550258-19.patch1.26 KBvalthebald
#18 550258-path-alias-preview-save-2.patch1.29 KBmr.baileys
#16 550258-path-alias-preview-save.patch1.84 KBmr.baileys
#13 path-test.patch1.14 KBmr.baileys
#8 path-550258-8.patch1015 bytesgpk
#1 path-550258-1.patch1.02 KBjromine

Comments

jromine’s picture

jromine commented
StatusFileSize
new path-550258-1.patch1.02 KB

simpletest patch attached

Status: Needs review » Needs work

The last submitted patch failed testing.

gpk’s picture

gpk commented
Status: Needs work » Needs review

The new path API appears to have fixed #543608: path.module creates additional alias instead of modifying existing, after node preview for 7.x and it appears that this patch will still apply albeit with offset. Retesting...

gpk requested that failed test be re-tested.

Status: Needs review » Needs work

The last submitted patch, , failed testing.

Status: Needs work » Needs review

Re-test of from comment #1928480 was requested by @user.

Status: Needs review » Needs work

The last submitted patch, , failed testing.

gpk’s picture

gpk commented
Status: Needs work » Needs review
StatusFileSize
new path-550258-8.patch1015 bytes

Hmm seems the tesbot can no longer cope with CR-LF line endings. Trying again.

Status: Needs review » Needs work

The last submitted patch, path-550258-8.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

gpk up for a re-roll?

gpk’s picture

gpk commented

Well, erm, I might be persuaded.. ;)

Only thing is I'm not quite sure where all those fails appeared from in "Path alias functionality".

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
StatusFileSize
new path-test.patch1.14 KB
  • Re-rolled to keep up with HEAD
  • Added a missing period to
    +    // Change alias, preview, then save

Leaving this at CNW since I'm seeing the same fails for "Path alias functionality" on my local computer.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, path-test.patch, failed testing.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Title: Test path change preview » Test path alias changes after node preview followed by save
Status: Needs work » Needs review
StatusFileSize
new 550258-path-alias-preview-save.patch1.84 KB

The patch in #8 seems to be a mixture between D6 and D7. The failures were caused by using $edit['path'] (D6) instead of $edit['path[alias]'] (D7).

Rerolled, should pass the testbot's scrutiny this time.

edit: typo.

Status: Needs review » Needs work

The last submitted patch, 550258-path-alias-preview-save.patch, failed testing.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs work » Needs review
StatusFileSize
new 550258-path-alias-preview-save-2.patch1.29 KB

Against a fresh version of HEAD.

valthebald’s picture

valthebald
Location Sofia
commented
Version: 7.x-dev » 8.x-dev
StatusFileSize
new path-alias-preview-test-550258-19.patch1.26 KB
valthebald’s picture

valthebald
Location Sofia
commented
Issue tags: +Needs backport to D7

Bumping version and marking as needing backport.

Status: Needs review » Needs work

The last submitted patch, path-alias-preview-test-550258-19.patch, failed testing.

valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs work » Needs review
StatusFileSize
new path-alias-preview-test-550258-23.patch1.38 KB

alansaviolobo queued 23: path-alias-preview-test-550258-23.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 23: path-alias-preview-test-550258-23.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new path-alias-preview-test-550258-26.patch2.29 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 26: path-alias-preview-test-550258-26.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

catch’s picture

catch
he/him
Primary language English
commented
Category: Bug report » Task
Issue tags: +Bug Smash Initiative

Adding test coverage is a task. Not clear if this is still relevant for 9.x or not.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.