see patch
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | l10n_community_block_help.patch | 1.9 KB | tobiasb |
| #2 | l10n_community_block_help.patch | 1.72 KB | tobiasb |
| l10n_community_block_help.patch | 12.11 KB | tobiasb |
see patch
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | l10n_community_block_help.patch | 1.9 KB | tobiasb |
| #2 | l10n_community_block_help.patch | 1.72 KB | tobiasb |
| l10n_community_block_help.patch | 12.11 KB | tobiasb |
Comments
Comment #1
gábor hojtsyGood suggestions!
I've committed an all-whitespace cleanup for the module, so I'm hopeful that you can reroll this patch with only the concrete changes. Please do.
Comment #2
tobiasbReroll
Comment #3
gábor hojtsy- There are whitespace issues in the first hunk of the patch.
- In the second one, you query the blocks table, but you do not include the current theme key. May be a nitpick, but a block can theoretically be setup different ways in different themes.
Comment #4
tobiasbComment #5
gábor hojtsyThank you! Renamed $blockcustom to $customizable and committed that. Keep these nice improvements coming!