see patch

CommentFileSizeAuthor
#4 l10n_community_block_help.patch1.9 KBtobiasb
#2 l10n_community_block_help.patch1.72 KBtobiasb
l10n_community_block_help.patch12.11 KBtobiasb

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Good suggestions!

I've committed an all-whitespace cleanup for the module, so I'm hopeful that you can reroll this patch with only the concrete changes. Please do.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
StatusFileSize
new l10n_community_block_help.patch1.72 KB

Reroll

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

- There are whitespace issues in the first hunk of the patch.
- In the second one, you query the blocks table, but you do not include the current theme key. May be a nitpick, but a block can theoretically be setup different ways in different themes.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
StatusFileSize
new l10n_community_block_help.patch1.9 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thank you! Renamed $blockcustom to $customizable and committed that. Keep these nice improvements coming!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.