Hi all!
I've been trying to port this Smileys module to Drupal 4.7 and now I need some help from someone who is a developer..
I ran the http://lullabot.com/formupdater with the cvs code which also was patched with the case sensitive patch and I got it through and it can be activated in Drupal but when I try to use the admin tool of the smileyes I can see the list of smileys but no images are displaying and when I try to add or edit I'm getting the word

Post

and then it stops and I can't do anything..

So I really need your help to get this module to work.. I think we all need smileys at our drupal site, don't we :)

Best regards

Comments

smilodon’s picture

HEY, THIS GUYS NEEDS HELP , SO HELP HIM !!!
... please.

fallacious’s picture

Here's what I get: The 'edit' and 'add' forms display "post"

In a test post

:-) displays as p>Smiling

and

:-( displays as Sad

The filter seems to display the description insteed of the image.

The module file also looked more like a large patch file (there were -/+ lines in it)

smilodon’s picture

Im not a php coder, but cant u replace the Smile with a html Only local images are allowed. code ?
All im sayng is thath emoticons is a very important thing ! Ppl are used to express themselves with smileys.
Im sad :( , but my face is 90 degrees lifted, and i hate that !

Lappie’s picture

Yeah, the file attachment is screwed up; part code, part diff.

The issue with the cvs of smileys is that it seems that Drupal has changed the way how relative paths are resolved. I don't know if this is correct nor do I have searched for a reference for it on the site. However, what this means is that you have to make the paths to the smiley images absolute (to a certain extent).

For instance, if you change the example.mysql file to the following and then load in your DB (backup first!), then it should work (YMMV). Notice the initial slash before 'misc/smileys...'??

INSERT INTO smileys VALUES (1,  ':) :-) :smile:',  '/misc/smileys/smile.png','Smiling',1);
INSERT INTO smileys VALUES (2,  ';) ;-) :wink:',   '/misc/smileys/wink.png','Eye-wink',1);
INSERT INTO smileys VALUES (3,  ':( :-( :sad:',    '/misc/smileys/sad.png','Sad',1);
INSERT INTO smileys VALUES (4,  ':D :-D :lol:',    '/misc/smileys/lol.png','Laughing out loud',1);
INSERT INTO smileys VALUES (5,  '}:) }:-) :evil:', '/misc/smileys/evil.png','Evil',1);
INSERT INTO smileys VALUES (6, ':P :-P :tongue:',  '/misc/smileys/tongue.png','Sticking out tongue',1);
INSERT INTO smileys VALUES (7, ':O :-O :shocked:', '/misc/smileys/shock.png','Shocked',1);
INSERT INTO smileys VALUES (8, ':? :-? :puzzled:', '/misc/smileys/puzzled.png','Puzzled',1);
INSERT INTO smileys VALUES (9, '8) 8-) :cool:',    '/misc/smileys/cool.png','Cool',1);
INSERT INTO smileys VALUES (10,':jawdrop:',        '/misc/smileys/jawdrop.gif','Jawdropping!',1);
INSERT INTO smileys VALUES (11,':sick: :barf:',    '/misc/smileys/barf.gif','Barf!',1);

That's how it worked for me. Also for existing setups this is the easiest way to add the initial slash. Usually this shouldn't break your DB (unless you've added non-standard smileys).

A similar issue was also present for the quote-module. However, for that module you can find a patch lieing around somewhere that resolves all kinds of update issues.

fallacious’s picture

With the above database change, the smileys do appear on the page. The article's body beings with p> and the admin pages are still broken. Broken admin pages would be acceptable to me for the purposes of an upgrade to drupal 4.7, provided that the input filter works.

fallacious’s picture

StatusFileSize
new8.35 KB

Here's a version of the module that *seems* to work. YMMV.

If you find any bugs, please let me know. It would be nice if somebody could repackage the module, using the new installer...

fallacious’s picture

Status: Active » Needs review
StatusFileSize
new8.37 KB

The previous version made the input filter configs go into an infinite loop. Kludged version appended.

Steven’s picture

Status: Needs review » Active

Please post a proper patch.

fallacious’s picture

Relative to what? 4.6 or cvs?

fallacious’s picture

Status: Active » Needs review
StatusFileSize
new13.54 KB

Here's a patch relative to the cvs version.

The code is of "seems to work for me" quality.

desm0n’s picture

Priority: Critical » Normal

Did anyone ever get this to work ? Does the patch make it fully 4.7 compatable ? I'm not too hot on patches so can anyone provide a full module with install for test ? I'd love to have this filter on my 4.7 drupal.

Anonymous’s picture

hi,

i'd like to inegrate this module into my chatroom module, so i'd like to help with getting this module ready for 4.7.

cheers
justin

Steven’s picture

Status: Needs review » Fixed

Already has been updated.

Anonymous’s picture

Status: Fixed » Closed (fixed)