Performance settings per domain

TCRobbert - August 16, 2009 - 15:43
Project:Domain Access
Version:6.x-2.0-rc8
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I am currently developing a multiple news magazine system which will gradually add more magazines over time. Meaning we would like to go live 1 domain at a time.
This being said I was wondering if there is a possibility to set performance settings, like optimize css / js, per domain?

And if there is not I was wondering where I should look concerning which hooks I need to make it possible.

Thanks in advance

#1

agentrickard - August 16, 2009 - 15:59
Category:support request» feature request

A patch to Domain Conf would allow this - but it would need extensive testing.

Otherwise use hook_domainbatch() or hook_domainconf() as described in API.php.

Note: a proper patch would use hook_domainbatch() for each setting, within a 'Performance' group.

#2

TCRobbert - August 16, 2009 - 16:16

agentrickard thanks for the quick response as usual :)
Looking at the hooks it would probably take me quite some time to figure out all the angles to get a decent patch out. Any chance this feature request could find its way in the next release?

Possibly I could support this request with a donation?

#3

agentrickard - August 16, 2009 - 17:15

Possible, if it is very easy and creates no side effects. The problem with this feature is that all kind of things could go wrong, and it is very hard to test.

We are trying to concentrate on #512770: Stable release tasks for 6.x.2.0 to get a final release for DC Paris.

I can roll a patch, but other people would need to test it.

#4

TCRobbert - August 16, 2009 - 18:21

I would definitely be there to help you test. Thanks in advance :)

#5

agentrickard - August 22, 2009 - 21:00
Status:active» needs review

This will be a tough patch to test. It should work just fine. Some notes:

1) Since aggressive mode caching breaks Domain Access, it is not available.
2) Since block caching is incompatible with node access modules, it is not available.
3) I did not even try to handle the JS and CSS compression, since that opens up a very nasty set of problems.

So you have control over Cache on/off, Cache Lifetime, and Page Compression.

AttachmentSize
550684-performance.patch 3.65 KB

#6

TCRobbert - August 24, 2009 - 09:08

agentrickard:
As im not sure if my domain access upgraded correctly (see #557702: Missing $ret in update 6202) ill wait till I get word on that before giving the patch a try :)

Do you think that #3 out of your points will be totally impossible? As that is actually my main concern.

#7

agentrickard - August 24, 2009 - 13:49

The upgrade worked. That's just a nuisance message.

#3 will be very difficult to implement AFAIK.

#8

agentrickard - October 11, 2009 - 14:39
Status:needs review» patch (to be ported)

Committed as described.

#9

agentrickard - October 11, 2009 - 14:40

Updated patch includes some README fixes for the port.

AttachmentSize
550684-performance.patch 4.58 KB

#10

agentrickard - October 11, 2009 - 15:21
Status:patch (to be ported)» fixed

Someone else can port this if they need it.

#11

TCRobbert - October 19, 2009 - 20:52

Hey agentrickard,

I saw this issue got some new input so checked and realized I completely forgot to checkout your patch. Its been hectic at work and as soon as im able to take a look ill let you know.

Again thanks for the time and effort you put into this.

#12

System Message - November 2, 2009 - 21:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.