I am currently developing a multiple news magazine system which will gradually add more magazines over time. Meaning we would like to go live 1 domain at a time.
This being said I was wondering if there is a possibility to set performance settings, like optimize css / js, per domain?

And if there is not I was wondering where I should look concerning which hooks I need to make it possible.

Thanks in advance

CommentFileSizeAuthor
#9 550684-performance.patch4.58 KBagentrickard
#5 550684-performance.patch3.65 KBagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Category: support » feature

A patch to Domain Conf would allow this - but it would need extensive testing.

Otherwise use hook_domainbatch() or hook_domainconf() as described in API.php.

Note: a proper patch would use hook_domainbatch() for each setting, within a 'Performance' group.

TCRobbert’s picture

TCRobbert commented

agentrickard thanks for the quick response as usual :)
Looking at the hooks it would probably take me quite some time to figure out all the angles to get a decent patch out. Any chance this feature request could find its way in the next release?

Possibly I could support this request with a donation?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Possible, if it is very easy and creates no side effects. The problem with this feature is that all kind of things could go wrong, and it is very hard to test.

We are trying to concentrate on #512770: Stable release tasks for 6.x.2.0 to get a final release for DC Paris.

I can roll a patch, but other people would need to test it.

TCRobbert’s picture

TCRobbert commented

I would definitely be there to help you test. Thanks in advance :)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 550684-performance.patch3.65 KB

This will be a tough patch to test. It should work just fine. Some notes:

1) Since aggressive mode caching breaks Domain Access, it is not available.
2) Since block caching is incompatible with node access modules, it is not available.
3) I did not even try to handle the JS and CSS compression, since that opens up a very nasty set of problems.

So you have control over Cache on/off, Cache Lifetime, and Page Compression.

TCRobbert’s picture

TCRobbert commented

agentrickard:
As im not sure if my domain access upgraded correctly (see #557702: Missing $ret in update 6202) ill wait till I get word on that before giving the patch a try :)

Do you think that #3 out of your points will be totally impossible? As that is actually my main concern.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The upgrade worked. That's just a nuisance message.

#3 will be very difficult to implement AFAIK.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Patch (to be ported)

Committed as described.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 550684-performance.patch4.58 KB

Updated patch includes some README fixes for the port.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Patch (to be ported) » Fixed

Someone else can port this if they need it.

TCRobbert’s picture

TCRobbert commented

Hey agentrickard,

I saw this issue got some new input so checked and realized I completely forgot to checkout your patch. Its been hectic at work and as soon as im able to take a look ill let you know.

Again thanks for the time and effort you put into this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.