Let's test the unique logic of the mapper.

It's a good question whether it should live in feedapi_mapper.test or in a separate file, in feedapi_mapper_feedapi_node.test. I'd vote for feedapi_mapper.test, because mainly it tests core functionality, and not (only) something per-mapper specific.
However the other choice has also some good arguments :D

Fixed while testing: #551442: Fix of feedapi_node's unique logic , #551444: Dup $ sings to remove

It can be extended w/ testing multiple unique field.

CommentFileSizeAuthor
test_unique_logic.patch59.07 KBaron novak

Comments

alex_b’s picture

alex_b commented
Assigned: aron novak » alex_b
Status: Needs review » Reviewed & tested by the community

Looking good. Needs some cleanup in language, otherwise RTBC.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Priority: Normal » Critical

should be in FeedAPI mapper 2.0 beta 1 then

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed with minor cleanups to comments, thank you.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Fixed » Active

test/samples/unique.xml is missing

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Fixed

committed the missing file

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.