With the current apachesolr module you can't reach a dead end by clicking facet links. However, with apache solr views, it is possible, so I updated the block implementation to handle this case.
I figured I would motivate this change with the following urls:
Filter nodes by terms "dad" and "mom": http://www.mothersclick.com/conversations/all/7575,9363
Filter nodes by terms "dad" and "mom" by type "photos": http://www.mothersclick.com/conversations/photo/7575,9363
The first link shows that only two nodes match the term filter, both are type Question. But the secondary navigation allows the user to apply the type filter to this search.
Once the user clicks the Photos link, what needs to be shown there is a set of unclick links so that the user can unapply the term filters. And that is what this patch provides.
What you guys think? I know its not possible to achieve a dead end with Apache Solr module, but this makes the module more robust as other modules like Apache Solr Views abuse it :-D
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | all.png | 144.98 KB | Scott Reynolds |
| #1 | photo.png | 125.5 KB | Scott Reynolds |
| deadend_cvs.patch | 1.54 KB | Scott Reynolds |
Comments
Comment #1
Scott Reynolds commentedHopfully, this patch will pass QA with all other changesets and go live tonight. So I took screen shots.
All.png deals with just filtering by the terms
photo.png deals with filter by the terms and type photo
Comment #2
robertdouglass commentedHmmm. I'm leaning towards asking you to maintain this one for yourselves. Please try to convince me otherwise.
Comment #3
Scott Reynolds commentedShouldn't their be an unclick link whenever a filter is applied? Even if that applying that filter doesn't return any results?
Comment #4
damienmckennaThere should be a standard way to remove selected filters, especially with some of the complicated facet structures that can be built.
Comment #5
jpmckinney commentedPatch no longer applies. The code that the patch was modifying is probably currently in apachesolr_search_taxonomy_facet_block(). I'm quite sure this is no longer an issue with the new code (it's been a year). If this is still an issue please re-open this issue.