Download & Extend

xcvs-loginfo should use mysql_real_escape_string() not mysql_escape_string()

Project:CVS integration
Version:6.x-1.x-dev
Component:X-CVS scripts
Category:bug report
Priority:normal
Assigned:dww
Status:closed (fixed)

Issue Summary

In IRC, merlinofchaos pointed out http://drupal.org/cvs?commit=252248

That used to just have the message:

#545540 by Roger L

Looked like the accented o in his name confused the xcvs-loginfo script. Looking at the code, we're calling mysql_escape_string(). Reading the PHP docs, looks like we really want to be using mysql_real_escape_string() instead, since the later "tak[es] into account the current character set of the connection".

Comments

#1

Status:active» needs review
AttachmentSize
551766-1.xcvs-mysql_real_escape_string.patch 3.64 KB

#2

Status:needs review» fixed

Finally committed this to HEAD in anticipation of an official alpha release.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here