Smush core images

I have already created an issue regarding this #543888: use compressed images in drupal core but this seems to have better description so let me mark that as duplicate.

Tagging. If we don't lose anything visually, seems no reason not to do this.

I can't really be bothered to compare every single image. Would be nice if would have supplied an comparison chart. But yhea, as catch said - if there is no visual difference, its good to go

Wouldn't expect there to be any loss resulting from PNG optimization programs like those, so I'm for it. Subscribe.

Has my vote. Anybody else so we can RTBC?

I am doubtful whether this will make a noticeable difference, even for sites with pages that are heavily reliant on the icon set. We should instead bank on a CSS sprites approach and optimise the icon set there. Time is spent in HTTP requests instead of actual transfer for files this size. Someone with a different theme and icon set will have to redo this optimisation. Even so, it doesn't harm to have this in.

it doesn't harm to have this in.

Exactly. RTBC.

Just quickly, deekayen can you confirm that said warnings from Google Page Speed go away once you put the images this patch? I only saw a "before" screenshot, not an "after".

And thanks a lot for taking the time to lay out before/after images!

Additionally, let's make sure we have this procedure documented somewhere so whenever a new image is added to core we can make sure this tool has been run on it. It's useful for contributed modules as well.

@figaro CSS sprites are a good idea, but we'd need something which generates them - adding a sprite to core is a maintenance nightmare. I don't think this'll make any measurable performance difference either, but it's good to have clean reports from those tools, so that when something shows up which is an actual problem, it's not obscured by the noise.

Sprites are good when you display many of its images on one page. In this case, a lot of the images are displayed on different pages, which could make sprites sub-optimal. Imagine you only want to use a single image of the sprint ...

Thats not 100% true Dries - remember that images are cached, so you would download it once and that would save http requests on other subsequent pages, assuming that the user actually visit multiple pages. Anyway, I think it wouldn't be a good idea to implement anyway - for logistic issues. We could always adopt an automated sprite generator to fix the logistic issue, though.

Fair enough, good point. Most websites have bounce rates of 50% and more so it could still be sub-optimal. ;-)

I'm happy to commit this "patch" but it is a bit time consuming to have to download all of these images. Happy to do so after code freeze though.

Packing them as a single zip file would help a bit.

Just to keep the focus on what this issue is about:
1- Avoiding a repeat alert on a tool that is maintained outside drupal (#18)
2- Having a process in place that ensures that this issue does not regress (#16)

I am happy to propose some text to our documentation team, if someone is willing to point out which page(s) this concerns. At the same time, it would help to have similar guidelines for the Drupal theming guide and I would like to propose the best practices guide (http://drupal.org/node/37156). Despite #21, no change in status.

Committed to CVS HEAD. Thanks!

Closed it may be, I have yet added the Smush suggestion to the following page: http://drupal.org/node/37156
Please review.

I think this works for now. Thanks!

Simple, yet great change :)

For the people who end up reading this issue and are interested in optimizing *all* the images on their site *automatically* (and optionally syncing them to a CDN): use the CDN integration module in combination with the File Conveyor daemon.

Follow-up #851496: Invalid to use the CSS background to display non-background images in Forum

As we are getting close to the UI freeze in RC1, can anyone please recheck this for beta3 again ... or even better as a last step before getting out RC1?

http://pornel.net/imageoptim/en is not available for for windows, else i would do it :(

Please use the following issue:
#935122: Compress Images using Lossless Techniques

It has the proper instructions for converting all the images in Drupal core quickly.

Excluding Jquery UI there are still a dozen images needing compression.

I've compressed and attached the remaining images which need compressing. They are not in the exact directory hierarchy, but are in folders based on theme which they reside.

For the jQuery UI, I've created a git branch and recommended the improvement in their project version control:
https://github.com/jquery/jquery-ui/pull/41

Committed to jQuery UI:
https://github.com/jquery/jquery-ui/commit/ff4154bb5d5a463cdb1750745b05e...

If we can get #36 in we can close this issue.

And before we close that issue, we need a way to make sure that all drupal's cvs committed images get optimized before.

But nice one on the jquery stuff :D !

Committed #36 to HEAD. Thanks!

At BADCamp, there was some concern from the Bartik maintainers that smushed images might remove transparency that previously existed? Except when Tim went digging, he wasn't able to actually find hard evidence of this. But that's the only potential reason to back out any of these changes. We'll see if this breaks anything, but in clicking around everything seemed copasetic.