Delete profile link has no confirmation

Bèr Kessels - August 18, 2009 - 08:42
Project:YUI Rich Text Editor
Version:6.x-2.33
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:active
Description

When clicking the "delete-profile" link there is no confirmation or POST there.

Quote from RFC HTML1.1

Implementors should be aware that the software represents the user in their interactions over the Internet, and should be careful to allow the user to be aware of any actions they might take which may have an unexpected significance to themselves or others.

In particular, the convention has been established that the GET and HEAD methods SHOULD NOT have the significance of taking an action other than retrieval. These methods ought to be considered “safe”. This allows user agents to represent other methods, such as POST, PUT and DELETE, in a special way, so that the user is made aware of the fact that a possibly unsafe action is being requested.

Naturally, it is not possible to ensure that the server does not generate side-effects as a result of performing a GET request; in fact, some dynamic resources consider that a feature. The important distinction here is that the user did not request the side-effects, so therefore cannot be held accountable for them.

Furthermore: If I chose to add an image in here <img src="http://your_drupal_site.com/admin/settings/yui_editor/-1/12345" /> loading that, would cause your profiles to be deleted (if you have admin permissions there).
This is a security hole called Cross Site Forgery Request: http://en.wikipedia.org/wiki/Cross-site_request_forgery

Marking as critical because of the latter.

 
 

Drupal is a registered trademark of Dries Buytaert.