Validation of the number of values in field_default_validate()

pls help me. thanks a lot

+++ modules/field/field.attach.inc	24 Nov 2009 12:19:17 -0000
@@ -690,6 +690,7 @@ function field_attach_load_revision($obj
+  _field_invoke_default('validate', $obj_type, $object, $errors);
   _field_invoke('validate', $obj_type, $object, $errors);

This could do with a small code comment to explain the purpose of each call, and their order. Why do we need to have two layers of validation functions?

A couple of points/questions:

+++ modules/field/field.default.inc	2 Dec 2009 23:36:07 -0000
@@ -21,6 +21,51 @@ function field_default_extract_form_valu
+  // Filter out empty values.
+  $items = field_set_empty($field, $items);

This snippet didn't make sense to me. I had to look at field_set_empty() to actually make sense of it, which is not a good sign. Either the code comment needs to be improved, or the function field_set_empty() needs to be renamed to be more self-explanatory. In fact, field_set_empty() has a todo * TODO D7: poorly named... -- it wouldn't hurt to rename the function.

+++ modules/field/field.default.inc	2 Dec 2009 23:36:07 -0000
@@ -21,6 +21,51 @@ function field_default_extract_form_valu
+  if ($field['cardinality'] >= 2 && $field['cardinality'] != FIELD_CARDINALITY_UNLIMITED) {
+    if (count($items) > $field['cardinality']) {

Does this test make sense? What if $field['cardinality'] == 1 but count($items) != 1 ... we wouldn't trigger an error. If this is a generic validation handler, we might want to make it 100% generic?

+++ modules/field/tests/field.test	2 Dec 2009 23:37:30 -0000
@@ -1597,6 +1628,46 @@ class FieldFormTestCase extends FieldTes
+   * Tests widgets handling multiple values..

Only needs one point.

Looks good now. Committed to CVS HEAD. Thanks!

This patch broke OptionsWidgetsTestCase, since it uses methods which are undefined in the class inheritance. This is another fire we have to put out before #560646: Fatal PHP errors don't cause tests to fail can land, so we can fix the test bot which is currently totally blind to these errors. The first one is:

Fatal error: Call to undefined method OptionsWidgetsTestCase::assertFieldValues() in modules/field/modules/options/options.test on line 88

Most of the field tests extend DrupalWebTestCase, which isn't logical since there is already a parent class for them to use, FieldTestCase. I tried to create a patch, but I could not get OptionsWidgetsTestCase to extend FieldTestCase (which has the methods in question), because I am getting some random crash:

Fatal error: Undefined class constant 'MYSQL_ATTR_USE_BUFFERED_QUERY' in includes/database/mysql/database.inc on line 31

Which I think is related to my installation of PDO. Anyhow, we need to fix OptionsWidgetsTestCase fatal errors. Then I want to create an issue examining the class inheritance in our tests.

Also, I just noticed this, list.test (a required module) implementing:

class ListFieldUITestCase extends FieldUITestCase {

which inherits from field_ui.test (an optional module), this is totally whacked out :P

yched: thanks.

Committed to HEAD. Thanks!