As per title, the latest dev version of D7 brings lots of errors with cvs_deploy e.g.

otice: Undefined property: stdClass::$filepath in cvs_deploy_get_project_name() (line 141 of /Library/WebServer/Documents/drupal-head/sites/all/modules/cvs_deploy/cvs_deploy.module).

Pobster

CommentFileSizeAuthor
#6 552506-6.cvs_deploy_d7_file_api.patch1.57 KBdww
#4 552506-4.cvs_deploy_d7_file_api.patch701 bytesdww
cvs_deploy-1.patch757 bytespobster

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs work

Thanks for the report. However, probably D7's file handling changed, and the data structure we're inspecting doesn't work like it used to. Just ignoring it if it's not where we think it is won't help us here. It might prevent the PHP notices, but it's going to break the module. We need to see how this data currently works in D7 and use it appropriately...

pobster’s picture

pobster commented

Yup, that is a good point - I suppose it is a bit early to be making assumptions about whether the file handling change is permanent or otherwise. Still at least the patch will cover up the messages in the meantime - and the module does seem to still work for me in the areas I use it in (drush and version numbers on the admin/build/modules page).

Thanks for the work,

Pobster

dww’s picture

dww
we/he/they
commented

This module is tiny and "chasing HEAD" as much as possible so it can be used by folks developing and testing D7. Even if the file handling changes again, it'd be worth figuring out how the file handling currently works and fix this accordingly. It really shouldn't be hard at all if you turn on devel.module and throw in a dvm($file); in that function and see what's what.

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Needs work » Needs review
StatusFileSize
new 552506-4.cvs_deploy_d7_file_api.patch701 bytes

Like so. ;)

pobster’s picture

pobster commented

Heh, beautiful! I have to confess when you said the magic words "chasing HEAD" I did think to myself that you're probably right - it'll change next week, so I didn't bother looking into it yet.

Thanks, and thanks for the module - I use it on all of my Drupal environments,

Pobster
edit: and yep, patch works just fine for me

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 552506-6.cvs_deploy_d7_file_api.patch1.57 KB

Actually, that patch wasn't complete... This should be even better.

dww’s picture

dww
we/he/they
commented

FYI: Looks like this was broken by #517814: File API Stream Wrapper Conversion.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

In my testing, this works. Committed to HEAD.

pobster’s picture

pobster commented

Aye, yep I've tested it extensively today and it looks good to me too.

Thanks,

Pobster

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.