Posted by dboulet on August 18, 2009 at 4:34pm
3 followers
| Project: | Columns filter |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | dboulet |
| Status: | closed (fixed) |
Issue Summary
I thought it would be really nice to have this module work with WYSIWG editors, in much the same way that the teaser break button works in WYSIWYG API.
Comments
#1
Definitely!
I think I saw the wysiwyg module has an API for Drupal modules to provide button plugins. This would be the way to do it so we only work with that one API and not dozens of individual editors. See http://drupal.org/node/152046
Again, I haven't time to look at this myself, but I'll gladly commit patches.
#2
More details here: http://drupal.org/node/372826
#3
Great, thanks. I think I'll attempt to tackle this later this week if I get the chance.
#4
Ok, here is the patch for the WYSIWYG API plugin. I've included the patch to columns_filter.module and the entire zipped 'plugins' folder seperately—I thought it would be simpler that way. To use the plugin, just unzip the plugins.zip file to the columns_filter module directory after applying the patch.
#5
Great stuff!
Works like a charm :)
The HTML when I switch off the wysiwyg looks dreadful but I assume that's just a consequence of wysiwygs and the rendered node is all fine.
I've committed it, with just a small tweak to the hook implementation -- I doubt we will ever need $type = editors here so an if statement is easier to read than a switch.
#6
New release will be up shortly.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.