Needed it for my site, so I've updated it for 4.7

Pobster

Comments

pobster’s picture

Oh erm, for some reason the filter_settings() part doesn't display? Don't know why, but I never used it anyway...

...Still it doesn't throw up any errors and everything appears to work fine as-is.

Pobster

pobster’s picture

StatusFileSize
new10.99 KB

My mistake... It was fine, but now it's also collapsable ;o)

Pobster

pobster’s picture

If you're wondering why I got confused it was because the Instructions didn't (and still don't) display properly. Maybe form_items have changed in 4.7 API? I dunno, couldn't work it out :o( Still, it's only the Instructions - everything else on the form appears to be fine.

Pobster

pobster’s picture

Ah okay I worked it out (and apologies for the multiple posts...)

Here:

$form['filter_attached_node']['attached_node'] = array(
    '#type' => 'item',
    '#title' => t('Instructions'),
    '#default_value' => t('This filter translates special node tags into thumbnailed representations that link to other nodes. 
      Syntax: [node:node_id,param1="val1",param2="val2"]; every param but node_id is optional.
      Each list below should be a comma separated list (no spaces) of what node properties users are
      allowed to override for the purposes of displaying a node.  E.g. <em>title,res,border</em>'),
  );

Change '#default_value' to '#value' and everything will work fine.

Pobster

sun’s picture

Title: Updated to 4.7 » Update to 4.7
Version: 4.5.x-1.x-dev » master
Category: support » bug
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new10.5 KB

Attached patch against HEAD - based on pobster's work.
I've tested attached_node with Drupal 4.7.2 and it works fine.

Without this patch Drupal filter settings break, so it has to be committed urgently.

javanaut’s picture

Assigned: Unassigned » javanaut
Category: bug » task
Status: Reviewed & tested by the community » Fixed

Sorry for neglecting this for so long. I've committed the latest module that sun attached. I tested it out on Drupal 4.7.3 and it appears to function properly. Thanks to both of you for contributing.

Anonymous’s picture

Status: Fixed » Closed (fixed)