With Drupal 7 we embarked on a rewrite of most of Drupal's part, now that we are introducing the CCK UI. We need to make sure that in conforms with the new standards we set in [#501452]. One of the major issues is all the technical implications that come with creating and editing a CCK field which should be made more clear, mostly by removing and rewording the existing descriptions.

CommentFileSizeAuthor
#6 cckui_552620.patch5.39 KBlisarex
#4 body_field_label.png5.82 KBlisarex
#4 content_types_intro.png9.58 KBlisarex
#4 delete_content_type.png18.66 KBlisarex
#4 display_author.png6.07 KBlisarex
#4 submission_guidelines.png11.5 KBlisarex
#4 cckui_552620.patch5.39 KBlisarex

Comments

rickvug’s picture

rickvug commented
Component: base system » field_ui.module

Moving to field_ui component now that CCK UI is in core.

lisarex’s picture

lisarex commented
Assigned: Unassigned » lisarex

Will have a look today.

dman’s picture

dman commented

Is this related to #560330: Make Field UI description more user-friendly ?

lisarex’s picture

lisarex commented
StatusFileSize
new cckui_552620.patch5.39 KB
new submission_guidelines.png11.5 KB
new display_author.png6.07 KB
new delete_content_type.png18.66 KB
new content_types_intro.png9.58 KB
new body_field_label.png5.82 KB

There are several updates in this patch that tidy, clarify and correct some of the UI text in here. Screenshots are attached for all changes apart from the first two which are simply capitalizing the word 'Add'.

dman: Thanks for checking. There's no overlap with #560330. This patch is for the UI text.

I just noticed the field settings page could use some love so will make a separate issue for that.

heather’s picture

heather commented
Status: Active » Needs review 
+++ modules/node/node.module	2009-10-25 16:46:36 +0000
@@ -90,7 +90,7 @@
+      return '<p>' . t('Individual content types can have different fields, behaviors, and permissions assigned to it. Save the new content type, then edit it to add mew fields.') . '</p>';

Mew fields! I think your cat wrote this patch. ;)

I didn't install and run this patch. Let's see the test-bot try it out.

I think you might have better luck submitting individual patches for each section? I'm not sure. I tried something like this before and it sort of languished.

This review is powered by Dreditor.

lisarex’s picture

lisarex commented
StatusFileSize
new cckui_552620.patch5.39 KB

Spotted a typo (mew should not appear!) so use this patch instead (which matches the screenshot), thanks.

lisarex’s picture

lisarex commented

Ah, you got me :) I can do indiv. patches if that'll help --- will they need to be in separate issues though?

heather’s picture

heather commented

I don't know, I do know webchick told me about "killing kittens" when you have a patch that affects many different components.

And I know how much you love your cat, and I do too. So... not sure if this is a kills kittens thing. I do know there may be existing issues out there which could be duplicated in this uber-patch.

#202533: Improve help texts in "add content type" is related maybe? is it a duplicate?

{edit: Bojhan confirms, this is too much to review at once, so best to break up into component issues, then link to each from here for posterity}

lisarex’s picture

lisarex commented
Title: [meta-issue] Rewrite descriptions of content types UI » [meta-issue] Rewrite descriptions of CCK UI
Component: node.module » field_ui.module

Cool, I have broken this down into smaller issues/patches:

#614316: improvements to body field label and submission guidelines

#614324: Node UI text improvements to author display settings

#614358: UI text improvements to 'Delete' content type confirmation message

#614396: Clarify UI text on page for adding new content types

yched’s picture

yched commented
Component: field_ui.module » node.module

None of the changes here are related to Field UI.
Also, note that the 'Body label' field will be gone from the 'edit content type' screen when we're done with #553306: Make nodes have no body field by default. Remove deprecated APIs for body field.

yched’s picture

yched commented
Title: [meta-issue] Rewrite descriptions of CCK UI » [meta-issue] Rewrite descriptions of content types UI
lisarex’s picture

lisarex commented
Title: [meta-issue] Rewrite descriptions of CCK UI » [meta-issue] Rewrite descriptions of content types UI
Component: field_ui.module » node.module
Assigned: lisarex » Unassigned

This can probably be made inactive now (see comment 9) unless there's further work to be done around this issue.

Status: Needs review » Needs work

The last submitted patch failed testing.

Bojhan’s picture

Bojhan commented
Version: 7.x-dev » 8.x-dev

Pushing this to Drupal 8, we might need to rewrite parts given on how the UI will evolve then and any testing we do on Drupal 7 but given the text-freeze it doesn't seem this meta issue should stay for 7.

xjm’s picture

xjm
she/her
Primary language English
commented
Component: node.module » node system
Issue summary: View changes

(Merging "node system" and "node.module" components for 8.x; disregard.)

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)

Looking at the patch some of the changes are now in core. I tracked one to #2528340: Improve description text for 'Content types' item on the Structure page.

I think it is time to close this.