Manage Fields and Display Fields links from the Content Types operation table

Bojhan - August 18, 2009 - 17:48
Project:Drupal
Version:7.x-dev
Component:node system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:D7UX, Usability
Description

You are now unable to manage your fields directly from the content types page - we need to add this to the operations table.

Quicksketch suggested we should also have the Display Fields.

#1

yched - August 18, 2009 - 18:24
Component:field system» node system

That's not a field issue anymore, but for fieldable types.
Also, we'll need similar links on the 'vocabularies overview table' at admin/structure/taxonomy

#2

jhedstrom - November 7, 2009 - 03:48
Status:active» needs review

The attached patch adds the manage fields and manage display links to the content type admin screen.

AttachmentSizeStatusTest resultOperations
manage_fields.552654.patch972 bytesIdleFailed: Failed to apply patch.View details | Re-test

#3

System Message - November 7, 2009 - 03:55
Status:needs review» needs work

The last submitted patch failed testing.

#4

jhedstrom - November 7, 2009 - 05:29
Status:needs work» needs review

Ah, I guess the test bot can't apply git patches. Here's a cvs diff.

AttachmentSizeStatusTest resultOperations
manage_fields.552654.patch1.12 KBIdlePassed: 14699 passes, 0 fails, 0 exceptionsView details | Re-test

#5

yched - November 7, 2009 - 15:56
Status:needs review» needs work

Thanks for tackling this !
- I'd suggest moving 'delete' at the end, though.
- we need to check whether field_ui.module is enabled first. If not, the links go to a 404.

+ a screenshot would probably help this being reviewed and committed ?

#6

Bojhan - November 7, 2009 - 19:14

Agreed with yched, can't apply patches so waiting for a screenshot in order to set this RTBC

#7

jhedstrom - November 8, 2009 - 01:29
Status:needs work» needs review

This patch does the 2 things yched suggested (delete to the end, and checks for the field_ui module). Also, attached is a screenshot.

AttachmentSizeStatusTest resultOperations
manage_fields.552654.patch1.38 KBIdlePassed: 14702 passes, 0 fails, 0 exceptionsView details | Re-test
manage_fields.png36.79 KBIgnoredNoneNone

#8

yched - November 8, 2009 - 01:55

Code-wise, this works for me. I'll let Bojhan validate.

#9

moshe weitzman - November 8, 2009 - 03:36

looks good to me ... test bot can apply git patches if you use the --no-prefix option.

#10

Bojhan - November 8, 2009 - 11:47

I can confirm it works, any idea where all the spacing comes from though? Look at the spacing between edit and manage field and between manage field and display fields.

#11

jhedstrom - November 8, 2009 - 22:02

Regarding column width, it appears to be the nature of tables that are pushed to 100% width. Attached is a screenshot from FF3.5 with the 100% table width disabled. Without specifically targeting this table/column in the theme, I'm not sure if there is a general fix.

AttachmentSizeStatusTest resultOperations
manage_fields_table_width.png36.53 KBIgnoredNoneNone

#12

Bojhan - November 8, 2009 - 23:50
Status:needs review» reviewed & tested by the community

OK, RTBC - we can do styling cleanups later more consistently.

#13

sun - November 12, 2009 - 01:18

Interestingly, the same output could be achieved with contextual links. ;) Just want to mention possibilities for D8.

#14

Dries - November 12, 2009 - 06:52
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. We can continue to discuss 'contextual links' if desired.

#15

yched - November 12, 2009 - 11:00

jhedstrom: Thanks ! Care to do the same with admin/structure/taxonomy/list ?

sun: I do think a link to 'manage fields' - or at least 'edit content type' would definitely makes sense in node contextual links.

#16

jhedstrom - November 12, 2009 - 16:46

#17

sun - November 12, 2009 - 20:40

What I meant is that the output we see here - and perhaps "operations" in general - _are_ contextual links.

manage_fields.links_.png

AttachmentSizeStatusTest resultOperations
manage_fields.links_.png111.45 KBIgnoredNoneNone

#18

System Message - November 26, 2009 - 20:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.