not every form has $form['type']['#value'] and form['taxonomy'] set!
please add

error_reporting(E_ALL);
ini_set('display_errors', TRUE);
ini_set('display_startup_errors', TRUE);

to your settings.php to show all these PHP warnings (if your server is not already configured to do so) and test a bit around.

CommentFileSizeAuthor
#4 552874.patch1.12 KBroderik
content_taxonomy-fix-php-notices.patch713 byteseMPee584

Comments

mh86’s picture

mh86 commented
Status: Needs review » Fixed

I'm still not getting any warnings, but patch looks good and makes sense, so I committed the patch. Thanks

eMPee584’s picture

eMPee584 commented

thx for committing..
and you will get warnings once your site forms are being abused by spam bots..

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 552874.patch1.12 KB

Patch was incorrect. Now the code is not executed if !isset($form['taxonomy']). And it should.

This change unfixed #391906: "Illegal offset type in" warnings on node preview. (which means your rc2 release has that error again)

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented

patch works great!! thanks!
But here a problem. Taxonomy fieldset became visible on node edit form.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented

Yes, I have seen that too.
This is a side effect of the way mh86 has fixed things.

crea's remark is right, in http://drupal.org/node/391906#comment-1809896 : in order to really fix issue #391906 without getting this empty Taxonomy fieldset on the form, you have to do it differently. But that is a lot of coding work. Very tricky work, because you need to work around some ugly details in D6 core (sorry I forgot details).

Oh well. At least it works. I'm glad mh86 has at least fixed things, and I'll live with the Taxonomy fieldset on the edit form; am not prepared (yet?) to do that much work, to make it disappear.

mh86’s picture

mh86 commented
Status: Needs review » Fixed

Patch from #4 committed, thanks :)
hope this finally fixes this issue. hacking around in content taxonomy because of a core bug causing these annoying warnings is really not funny...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.