Only local images are allowed.

Only local images are allowed.

- the 'A local file system path…' bits are repeating the respective labels.
- 'This directory must exist…' Yes. You can't even install without having them, right? Does that need to be repeated here? Wouldn't it be more appropriate to make the text fields 'required' then?
- 'This setting is used as the preferred…" is repeating the label.

CommentFileSizeAuthor
#4 filesystemdescriptions2.patch2.37 KBBojhan
#3 filesystemdescriptions2.patch2.36 KByoroy
filesystemdescriptions.patch2.32 KByoroy

Comments

yoroy’s picture

yoroy commented

argh, forgot the input format that allows the img tag:

Only local images are allowed.

Only local images are allowed.

Bojhan’s picture

Bojhan commented

According to our lovely, http://drupal.org/node/501452 - we should avoid using words as "Should". Which I think applies here as well. But lets see how...

yoroy’s picture

yoroy commented
StatusFileSize
new filesystemdescriptions2.patch2.36 KB

Ok. rephrased "Should not be…" to "Make sure this directory is not…

Bojhan’s picture

Bojhan commented
StatusFileSize
new filesystemdescriptions2.patch2.37 KB

Small change, This path must be relative to the Drupal installation directory and be accessible over the web.

dries’s picture

dries commented

The fact that these directories should be writable by Drupal seems important -- it suggests the user that he'll need to take an extra action; e.g. make the directory writeable. Not?

catch’s picture

catch
he/him
Primary language English
commented

If the current directory isn't writable, this page does a drupal_set_message() (not in validation because it's possible to set the directory to non-writable via other means). So that information gets conveyed, but we have a decision to take on whether we want to convey it on the form or only if someone gets it wrong. I'm not sure either way.

yoroy’s picture

yoroy commented

My take was you can't even install Drupal. Consequently, you'll never get to this screen without having writable folders present there.
So, this is only for when you want to change these paths on an existing site, right? Hmm. I know I keep forgetting to set folders to writable each time I install Drupal, so the info is useful. The question is if the description will be read before changing the path. Not sure either.

catch’s picture

catch
he/him
Primary language English
commented

Yes you only need to do visit this page to change paths on an existing site. Another factor here is if you're actually moving the directory, you probably copied/moved it rather than creating a new one which in most cases will leave permissions/ownership intact.

Status: Needs review » Needs work

The last submitted patch failed testing.

yoroy’s picture

yoroy commented

Will revisit after code freeze

yoroy’s picture

yoroy commented
Version: 7.x-dev » 8.x-dev

Strings frozen for D7

yoroy’s picture

yoroy commented
Assigned: yoroy » Unassigned
Issue tags: -Needs text review

Might revisit this later, but for now, usassigning.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wylbur’s picture

wylbur commented
Issue summary: View changes
Status: Needs work » Closed (outdated)
Issue tags: +#Nashville2018

In drupal 8, there are no setable fields, as this is controlled by settings.php.

The descriptions are clear and provide detailed information.

Marking this as outdated, please reopen if appropriate.