Currently the master node context goes missing. Must-fix for g.d.o and 2.0 release, for great justice.

Comments

adam_b’s picture

adam_b commented

By "master node context" do you mean sidebars? If so, subscribing ;)

markus_petrux’s picture

markus_petrux commented

I would be glad to help, but I would appreciate clarification in #566882: New Code but DEV Version not updated.

joshk’s picture

joshk commented

Recent commits get this most of the way there. However, we are still missing the $context->identifier which breaks a lot of things. For now, I'm hard-coding one in so that we can use views arguments correctly, but I need to get some knowledge from merlinofchaos in order to fix it.

Basically, the issue is that when we run our og_panels_load_display() function, we explicitly declare the contexts like so:

    $display->context = array(
      'argument_nid_1' => ctools_context_create('node', $group_node),
      'relationship_og_1' => ctools_context_create('og', $group_node),
    );

It could be that I'm just not grokking the internals of context.inc, but this has always been a bit of a kludge. Maybe it's ok to hard-code an identifier here, or maybe the whole system needs to be more elegant (e.g. some clever use of args in our page_delagator task). Will talk to merlin and get his opinion.

joshk’s picture

joshk commented
Status: Active » Closed (fixed)

Earl blesses this, and panels_node.module shows the way!