The customer order review table is always empty in rc5, i.e. it always shows This order contains no products.

The argument to op_products_customer_table() should be named $order and not $products. It seems to have been reverted sometime after the uc_price_types patch was commited.

CommentFileSizeAuthor
#1 553224_customer_order_table.patch429 bytesfenstrat

Comments

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Active » Needs review
StatusFileSize
new 553224_customer_order_table.patch429 bytes

Will rc5 be as short lived as rc4?

Bit of a show stopper this one.

rszrama’s picture

rszrama commented
Status: Needs review » Needs work

This patch doesn't seem to be enough. The function was changed further down to expect a $products array, but obviously it's not working. : ?

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

No, the op_products_customer_table function expects $order->products as an array, not $products.

It appears that the uc_price_types patch didn't change the name of the argument for op_products_customer_table - as per the patch above it should be $order and not $products

Island Usurper’s picture

Island Usurper commented
Status: Needs work » Fixed

Gosh, that mistake's been in that patch from the very beginning, hasn't it? Whoever wrote that needs to learn to test all of his changes. :P

Thanks for the patch. Committed.

DeskRocket’s picture

DeskRocket commented

Working here. Thanks!

rszrama’s picture

rszrama commented

Works for me, too. Good on ya, Lurl.

jday’s picture

jday commented

updating my site with the patch fixed the user's orders display, thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.