Again :), here is the api patch, i've included the full package too, as i'm new to this patching thing and we have new ".install" files...

Changes:
- new formAPI stuff.
- code changes to conform with drupal coding conventions.
- creation of .install file (4.7 way to create the mysql table's automatically).

Pacheco

Obs.: StockAPI and Stock both have new patches too.

CommentFileSizeAuthor
#14 currency_api_0.patch687 bytespacheco
#10 currency_api.patch18.53 KBpacheco
#9 currency_2.patch28.74 KBpacheco
#7 currency_1.patch9.98 KBpacheco
#6 currency.zip14.38 KBpacheco
#5 currency_0.patch38.86 KBpacheco
#4 currency.patch39.15 KBpacheco
#3 currency.rar13.75 KBpacheco
currency.patch.tar.gz13.49 KBpacheco

Comments

hadishon’s picture

hadishon commented
Category: task » bug

I tried installing this on a 4.7 (released) version of drupal and it crashed the site. These are the errors I got:

Warning: Missing argument 2 for variable_get() in /httpdocs/includes/bootstrap.inc on line 263

Warning: Cannot modify header information - headers already sent by (output started at /httpdocs/includes/bootstrap.inc:263) in /kcholmim.org/httpdocs/includes/common.inc on line 266

Maybe something changed between when you submitted this patch and the 4.7 release?

pacheco’s picture

pacheco commented

Maybe something changed between when you submitted this patch and the 4.7 release?

Yes, its possible, i will have a look and upload a new version asap. Tks!

pacheco’s picture

pacheco commented
StatusFileSize
new currency.rar13.75 KB

easier than i thought...

please verify this new version.

tks again

pacheco’s picture

pacheco commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new currency.patch39.15 KB

This is the final version, it's ready to go in my opinion.

pacheco’s picture

pacheco commented
StatusFileSize
new currency_0.patch38.86 KB

just "diff -u"...

pacheco’s picture

pacheco commented
StatusFileSize
new currency.zip14.38 KB

and a full package, just in case...

pacheco’s picture

pacheco commented
StatusFileSize
new currency_1.patch9.98 KB

Text editor encoding solved, this one is a lot smaller, sorry...

kbahey’s picture

kbahey commented
Status: Reviewed & tested by the community » Needs work

There is still one form_checkbox in currency_api.module.

Please make a separate patch for it.

pacheco’s picture

pacheco commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new currency_2.patch28.74 KB

new one, i forgot to "diff -uN" (recursive)

most of the changes at currency_ap/currency_api.module are conding convention ones, this file got havier most because of that.

pacheco’s picture

pacheco commented
StatusFileSize
new currency_api.patch18.53 KB

ok, new separated patch

formAPI stuff and indentation conforming with conventions...

kbahey’s picture

kbahey commented

pacheco, I committed your changes.

One thing is missing: creating a .install file for the database table to be created.

pacheco’s picture

pacheco commented

this one doesn't use a database table Khalid... currency does not cache results, remember?

kbahey’s picture

kbahey commented
Status: Reviewed & tested by the community » Fixed

Thanks Pacheco. I confused it with Stock API.

Branched for 4.7 too.

pacheco’s picture

pacheco commented
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new currency_api_0.patch687 bytes

Just found an little error, last one please ;)

pacheco’s picture

pacheco commented
Assigned: pacheco » Unassigned
Status: Reviewed & tested by the community » Fixed

just changing the status to fixed

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)