The preview function for the base feed display handler incorrectly ignores the live_preview property which breaks views_embed_view() when used to render a feed. Attach patch fixes this. Thanks to killes for finding this.

CommentFileSizeAuthor
views_feed_preview.patch555 bytesneclimdul

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Reviewed & tested by the community 
+++ plugins/views_plugin_display_feed.inc
@@ -30,7 +30,10 @@ class views_plugin_display_feed extends views_plugin_display_page {
+    if (!empty($this->live_preview)) {
+      return '<pre>' . check_plain($this->view->render()) . '</pre>';
+    }
+    return $this->view->render();

Tested and it indeed fixes my bug.

This review is powered by Dreditor.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed! Except I said it was by killes. Sorry neclimdul. You get no credit. :/

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.