notice: Undefined index: terms_of_use_node_id in /terms_of_use.module on line 99.
when submitting the form the first time:
admin/settings/terms_of_use

Comments

jennifer.chang’s picture

jennifer.chang commented

all on a fresh install, the second time I submitted the form, after having specified the nid,
if I reload the form and click 'I prefer to specify the node id', the nid is unset again, so the variable is lost somewhere...

kars-t’s picture

kars-t commented
Status: Active » Fixed

Seems to be fixed as I can't reproduce it.

jennifer.chang’s picture

jennifer.chang commented
Status: Fixed » Active

How was it fixed since there was no commit in a year?

check your development installation:
#761780: Plenty of E_ALL notices in modules developed on installation with Drupal tarball

kars-t’s picture

kars-t commented
Status: Active » Needs work

Hi jennifer.

The one side of this issue is about E_ALL. Would be easier if you state first that this is an E_ALL problem ;)

The thing in #2 is a "by design" behavior of this module. I don't think it is nice but due to the JS handling switching to "Node by it's ID" will seem to loose the ID. This is not true because the script will not safe anything. But this will produce the E_ALL Error I believe as the field changed and you can only see the original value if you reload.

This will need some work. Feel free to provide a patch for this.

kars-t’s picture

kars-t commented
Status: Needs work » Fixed

I changed the algorythm a bit. I still don't like it but won't do a rewrite till next release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.