Hi

I found that it doesn't work with content profile (maybe it doesn't work at all, I am not sure, in fact, the only place I use this is for content profile fieldgroup tabs)
this bug is different from another bug with content profile i found - http://drupal.org/node/554014

for me all tabs are shown ok in layout (Zen theme). the problem is that tabs don't work. Eveything content from all tabs is right under the first tab, so the page is very long.
there are two options when i click on the tab
if anchor of the tab (and the tab name) have no localized characters, it do nothing
if the tab has localised characters, then anchor too, it seems like #tabs-osobnosť , it throws javascript error
uncaught exception: jQuery UI Tabs: Mismatching fragment identifier.
probably it would be better doesn't use localised strings in anchors (use transliterate, e.g. replace č with c, etc).
However, the biggest problem is what I wrote above, that everything is under the first tab, not right under appropriate tabs.

thanks for the fix
Igor
http://www.somvprahe.sk

Comments

mzi’s picture

mzi commented

subscribing; got exactly the same issue, maybe by updating Tabs?

igorik’s picture

igorik commented

definitly it is because new tabs and new cck fieldgroup tabs, I am not sure which from those has the problem.
When I replaced them with version I used before (few months old), everything works fine.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

I rolled back a change I'd made to tabs module to prevent the issue with special characters.

Could you test again with the current dev version of tabs to see if that helped? Thanks.

mariano.barcia’s picture

mariano.barcia commented

I just tried, and no luck.

Latest dev version of this module (CCK Fieldgroup Tabs)
Latest dev version of Tabs

It was working fine until the update to the latest stable versions made today. Well, actually, this new version solved a problem with registration so I'd like to benefit from that patch (= I cannot rollback anyways).

I'll be looking forward to you updates thanks in advance.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for the update. It looks like the tabs dev version hasn't been rerolled yet with today's changes. Maybe you could get it from CVS or else try tomorrow.

igorik’s picture

igorik commented
Status: Active » Fixed

Hi

now it works like a charm. Thanks!

Just curious question, really are now tabs loaded by ajax by default (after click?)? Because it is so fast :) after click on the tab, that I didn't notice any difference from last tabs version, where every tabs were loaded on page load.

igorik’s picture

igorik commented
Status: Fixed » Active

Hi

I found that although it works fine on user profile page, it doesn't work at all on user registration page (with content profile field tabs)
There are no tabs and everything content on one page.
(maybe it is not allowed for anonymous? just an idea...)

thanks for the fix
Igor

mariano.barcia’s picture

mariano.barcia commented

I tried again with the latest dev version, and no luck. Perhaps I'm not having the same problem? I see this.

* Basic <a href='#' id='group_personal_infolink'><img src='/tplaxo/sites/all/modules/cck_field_privacy/padlock.png' alt='Privacy' /></a>
* Picture <a href='#' id='group_picturelink'><img src='/tplaxo/sites/all/modules/cck_field_privacy/padlock.png' alt='Privacy' /></a>
* About me <a href='#' id='group_about_melink'><img src='/tplaxo/sites/all/modules/cck_field_privacy/padlock.png' alt='Privacy' /></a>
* Work Information <a href='#' id='group_work_infolink'><img src='/tplaxo/sites/all/modules/cck_field_privacy/padlock.png' alt='Privacy' /></a>
* Work and education <a href='#' id='group_work_educationlink'><img src='/tplaxo/sites/all/modules/cck_field_privacy/padlock.png' alt='Privacy' /></a>

It looks like all the HTML markup is being escaped.

We're using cck_field_privacy, which was displaying the tabs OK before the new release.

mariano.barcia’s picture

mariano.barcia commented

Configuration A
Latest dev version of tabs package (v1.17 of the main module) from http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/tabs/.
Latest dev version of cck_fieldgroup_tabs package (v1.26 of the main module)
Latest dev version of cck_field_privacy, with a patch applied (http://drupal.org/node/518324#comment-1931746).

It shows the markup escaped, as described in #8 above. BTW, that string was pasted plain text here, and it is being displayed in a single line in the browser, with the proper format of the tabs. It seems that the problem is only the lenght of the text because the markup gets escaped. I will be reporting this to the cck_field_privacy issue queue.

Configuration B (w/o privacy)
Disabled cck_field_privacy, cleared the cache, double-checked the configuration of tabs and cck_fieldgroup_tabs and I'm still getting the problem described above originally by igorik (I'm using FF3). Tried with this patch also (http://drupal.org/node/555102#comment-1953334), but no luck.

It seems I'm not getting the right versions or caching something? Igorik could make it work. And the problem he mentions, is exactly what I want! (no tabs!).

Hope this helps, thoughts? Thanks!

mariano.barcia’s picture

mariano.barcia commented

I think I found the problem: check_plain() function should not be used to set the title. This function is being used in tabs.module (line 77) and cck_fieldgroup_tabs.module (line 168). Removed both invocations and the padlocks of cck_field_privacy are now showing up properly.

From http://drupal.org/node/28984

Form elements #description and #title
Examples:
$form['bad'] = array(
'#type' => 'textfield',
'#default_value' => check_plain($u_supplied), // bad: escaped twice
'#description' => t("Old data: !data", array('!data' => $u_supplied)), // XSS
);

$form['good'] = array(
'#type' => 'textfield',
'#default_value' => $u_supplied,
'#description' => t("Old data: @data", array('@data' => $u_supplied)),
);

Please notice that the issue originally described by igorik is still happening to me, where should I check to make sure my version is the latest version being used? Thanks in advance.

mariano.barcia’s picture

mariano.barcia commented

More info on this issue:
This issue is happening on edition and display. Workaround: enabling the "navigation" option in the settings fixes the problem (for now).

igorik’s picture

igorik commented

I can confirm that I have no cck fieldset tabs on user/register (using content_profile) with latest tabs dev version and cck_fieldgroup_tabs dev
version. With version few months ago older it works nice.
The bug with no tabs on user profile is fixed, but on user/register isn't.

however, I am using this new version, because I like it, and I like the way how it goes. But my users have veeeeery long register form now :)
- http://www.somvprahe.sk/user/register

thanks for your work
Igor

mariano.barcia’s picture

mariano.barcia commented

@igorik
Is there a real need to include all those fields in the registration form? In my case, I don't want tabs in the register page because IMO they add confusion to the form in a moment where the person should be very clear not distracted by anything, so he/she can actually become a member with no delay. And this is the preferred method of most of the websites out there, because creating a profile means work for your people and you don't want to make that process even harder for them. IMO, it's better to let them quickly signup/register, and after that, encourage them to complete their profiles gradually... Of course, this module could have this as a configurable option (display fieldgroups in tabs in the register page?) set by default to NO. Just my 2 cents... salud

igorik’s picture

igorik commented

Hi Mariano, maybe you are right and i will reduce my register form.The idea why i wanted this and why i think that it is a bug is that it worked with older versipn and with new version tabs are not shown on user/register.
So this can be a bug, but nedjo can fix it and add option to choose if tabs will be visible on register or not.
Have a nice day
igor

kenorb’s picture

kenorb commented

+1

kenorb’s picture

kenorb commented
Issue summary: View changes
Status: Active » Closed (outdated)

Drupal 6 is no longer officially supported. If you think this issue is still relevant for 8.x, feel free to re-open.