in attempting to thoroughly test the conversion of menu.module to the forms API, i stumbled upon an unrelated bug regarding resetting menu items. this is present in both the FAPI and non-FAPI versions of menu.module, so i'm submitting it here as a separate issue.

To repeat:

  1. add a new menu (e.g. "foo")
  2. add a new menu item to this menu, with "node/add" as the path (e.g. "add nodes")
  3. edit the existing "create content" menu item and move it from the "navigation" menu to "foo"
  4. reset the "create content" item now that it lives in "foo".

At this point, the "create content" menu item will completely disappear (and not reappear in the navigation menu, like you'd expect). all the children of "create content" will now be inherited by the "add nodes" custom menu you created in step #2. :(

i suspect this is a weird corner-case from the rehaul menu builder issue, but i'm not sure (and don't have time right now to investigate that theory). i'm a little reluctant to call this "critical", since it's a fairly weird process to reproduce, but it's possible this bug shows up in other cases, too. someone with strong feelings should definitely downgrade this to normal if they think this isn't worthy. ;)

sorry i don't have time to solve this and provide a patch at the moment. if no one else jumps on it in the next few days, i'll see what i can do.

thanks!
-derek

Comments

Zen’s picture

Priority: Critical » Normal

heh. We need a new category named 'exotic' for such issues :) Those steps are a little confusing. But this definitely appears to be an extreme case.

Downgrading.
-K

zympht’s picture

I'm experiencing this problem in 4.7.2. I don't think it is all that unusual to want to move menu items from Navigation to Primary Links. Here's what I did:

1. Added menu item to Primary Links menu with path 'privatemsg' and title 'inbox'
2. Clicked 'reset' on the 'view inbox' menu item in the Navigation menu. (the 'disable' link was not available)

The menu item disappears from Navigation menu, never to return.

I would be most appreciative if someone could look into this.

Thanks,
Jason.

zympht’s picture

I fixed my menus by gaining an understanding of a nuance of the menu system. If you "reset" a menu item whose path exists in another menu item, then the item is effectively deleted. If you want the system/dynamic menu item back, you must delete your custom item with the same path. Truncate the cache table if you don't see it come back right away.

The proper way to put existing paths on a new menu is to move their existing menu item by changing their parent.

magico’s picture

Verified and happening.
And this is a problem that can usually happen with other steps that envolves editing and reseting default menu items.

chx’s picture

http://drupal.org/node/18351 is related. As said there: do not hold your breath.

magico’s picture

Version: x.y.z » 5.x-dev
Status: Active » Closed (duplicate)