4.7 compatability

Can confirm this, it won't update the number of posts for example, running 4.7.0-beta6 and the cvs-version of flatforum.

Same thing here

Hi,

I've fixed the post count issue, does anything need fixing? Please provide some details or error messages, because I tested the CVS version of flatforum with Drupal 4.7 Beta 6 and everything seems fine.

Thank you.

Have you tested this with RC1? I can't seem to get it to work! (no difference whatsoever when the module is enabled/disabled)

I just test with 4.7 RC2, and pushbutton is the only default theme that flatforum works with properly using the install instructions. The others will need further template/theme editing I'd imagine and they'd work too.

Hi,

Now I can confirm that Flatforum is broken on several fronts with the latest RC, I'll work on fixing the module.

Thanks for the reports.

Hi,

I fixed the code and tested with RC3 and 3 themes: bluemarine, friendselectric, and pushbutton, Flatforum seems to work fine, would you please test and report back?

I apologize for the long delay by the way.

Thanks.

Doesn't work with box_grey. :(

The forum listings and thread listings are fine, but the threads themselves are a mess.

Is there any specific information that will help you?

Thanks for maintaining this, by the way. It's a great module!

Michelle

Do you have the site online so I can check? What version of Drupal, box_grey and flatforum are you using? Did you make any modifications to the theme?

On a fresh install of Drupal 4.7 RC3, box_grey 4.7 and flatforum CVS everything works fine, I also use this setup on a production site and it's working perfectly.

I can't come up with a CSS template that works everywhere, it would be great if I can check your site.

Thank you.

4.7 current cvs and box_grey 4.7 are working for me with flatforum.

AymAN, Could you provide me with the link to your production site so that I may be certain I have everything right?

jodo - Careful on the titles with issues. :)

Ayman - http://lacrosseareacameraclub.org/forum

If it's working on stock box_grey, then it's possible it's something in my setup. I've only made really minimal changes (like getting rid of first line indenting) but I have a lot of modules and stuff installed so maybe something else is messing with it. I'll try switching to stock box_grey and see if that sorts it.

Thanks,

Michelle

Ok, I tried stock box_grey and bluemarine and neither of them show the threads right. So it must be something else I have installed. I don't know what, though. I'd rather not have to disable every contrib module I've got installed... Any suggestions?

Thanks,

Michelle

MichelleC,

I checked your website and it is indeed messed up in IE, Firefox renders the threads fine however, upon further inspection it appears that the mess do happen on stock versions and without additional modules, I'll work on identifying the cause and fixing the code, the CSS needs some improvements anyway.

Thanks for the report.

jodo,

The site is http://www.csc-sy.net/forum , it runs Drupal 4.7 RC3 and the CVS version of Flatforum, but currently the old table-based template is used until I adapt the CSS version to look like the table-based one.

I use Firefox 1.5. I hadn't even looked at it in IE. It doesn't look right in Firefox to me. I'm wondering about your comment to jodo, though. Is it not _supposed_ to look like it did in 4.6? Maybe it's my expectations that are wrong? I was expecting it to look like your site does with the table look, not each comment in a seperated box. Does that make sense?

Thanks,

Michelle

Before I took over the project, flatforum used table tags to achieve the forum look, later I switched the template to div tags and CSS to achieve a similar forum look, now both 4.6 and 4.7 versions use CSS.

So no, the current version doesn't look like my site.

What I'll work on in the next few days:
* Debug the CSS code which broke in 4.7 for some reason.
* Enhance the look of forum threads.

Ok, I'll wait and see what you come up with, then.

Again, thanks very much for taking this over. I think the forums look 100% better with flatforum and am very glad to see it's going to work with 4.7.

Michelle

Hi Ayman,

Just tried the latest CVS (April 29 package) and everything seems to work fine now in the default Drupal themes, except the user avatars are not being displayed. I've tried setting a default avatar, uploading an avatar and various other settings such as disabling cache and clean URL's as well as setting the download method to public. After I set the download method to public I checked my log files and there is no request for any of the avatar filenames.

Hi brashquido,

Are you sure you enabled user pictures at admin/themes? Avatars are working perfectly for me.

Hi everyone,

I did some major work on Flatforum today, new stuff:

* Improved CSS code for both structure and look, making changes/improvements should be easier as well (using CSS code).
* #new and #comment-* link issues should be resolved now.
* Forum nodes should appear like normal nodes everywhere outside forums.
* .install file for Drupal 4.7.
* Heavily tested with Drupal 4.7, Bluemarine, PushButton, box_grey, and FriendsElectric, under Firefox 1.x, IE 6, and Opera 8.x.
(There is a minor issue with PushButton, please check the README.txt for details and a fix).

Please test once the new CVS package is created (or pull the new code off CVS), if you want to report an issue, please include:
* a description of what's wrong (a link/URL would be helpful as well).
* Your browser version.
* Drupal and Flatforum versions.

If all is well, I'll branch for 4.7.

Thank you.

Forum nodes should appear like normal nodes everywhere outside forums.

Awesome! I can't wait to try this out. That bit I quoted was something that drove me nuts in the 4.6 version because it made it impossible to promote forum nodes to the front page.

Thanks so much for all your work on this!

Michelle

Hi Ayman,

I've been trying out this new version and it looks really good. I am having two problems. The picture/Avatar is not appearing in the forums, and the title for the forum topics is not appearing. The titles for the comments are appearing. I do have show user pictures checked in the themes settings. Still no picture in the forums, though pictures are appearing on other kinds of nodes. Thanks. This forum really looks great overall!!

Paul

I can't say what's wrong on your system, but I wanted to say that avatars and forum titles are working for me, so it's likely something specific to your install. Sorry that's not a lot of help, but at least you know they _should_ be working and that it's not something lacking in the module. :)

Michelle

Hi Ayman, MichelleC, and all.

MichelleC, I appreciate your reply and, I'm glad to hear flatforum is working for you. I'm still having problems with flatforum. Your message prompted me to begin with a clean install of Drupal 4.7 and a fresh database. Presently, the only contributed module on the system is flatforum. I have installed flatforum several times, and I believe I am following the installation instructions explicity.

I am testing with Bluemarine. I get the same results when Bluemarine is in root/themes/theme or root/sites/www.example.com/themes/theme.

Here's the setup:

root/themes/bluemarine/template.php (identical to flatforum original)
root/themes/bluemarine/node-forum.tpl.php (identical to flatforum original)
root/themes/bluemarine/styles.css (flatforum.css styles appended to styles.css)
root/modules/contrib/flatforum/

Drupal 4.7
Flatforum cvs 06/05/2006
Browsers: Firefox 1.5.0.3, Opera 8.54, IE 6.0 (same problem in each)

User pictures are enabled in user settings and in the theme settings.

It continues to be the case that forum topics are missing the picture/avatar, the forum topic title, and also the links. The forum comments appear as expected.

Ayman, or anyone is willing to help me figure this out, please take a look at this temporary link: http://love.drumwave.net

Thanks for any help in advance.

Ayman, thank you for your work on this theme/module project. It looks fantastic.

Paul

I can verify it works in the B7 theme. But instead of modifying style.css.. you must modify base.css.

Hi pcwick,

Weird, the avatar/link behavior on forum nodes seems to be reproducible on vanilla Drupal, and can be solved by enabling post information for forum nodes, would you please enable it at admin/themes/settings and report back?

As for the node title, it appears at top of the page, wouldn't it be redundant if it appeared inside the node div as well?

Hi Ayman,

I am happy and embarrassed to report that your suggestion works!! Sheesh, how did I miss the checkbox for "forum topic" under "Display post information on" on the global theme settings? And yes, I agree that displaying the title in the forum topic would be redundant. Thanks for your help! Woo hoo!

Paul

Hi pcwick,

Glad everything is now in order :)

I'm going to close this issue and branch for Drupal 4.7, if someone has a problem, please open another issue, because we discussed like 10 issues here :P