Tabledrag breaks component UI for projects with tons of components

dww - August 20, 2009 - 17:32
Project:Project issue tracking
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:dww
Status:closed
Description

I noticed that the ordering of the Drupal core components was all fubar. I tried to fix it, but after making a few changes and trying to save, the order was still somewhat scrambled. Then I realized that the underlying weight field only has a delta of 15 options, and core has quite a few more components than that. ;)

I just changed it on d.o to use a delta of 50 and now it's working. I'll officially commit and deploy this in a bit. Just wanted to open an issue about it.

#1

dww - August 20, 2009 - 17:41
Status:active» needs review

Here's an even better patch -- instead of hard-coding a large number, we just dynamically set the delta based on how many components the project has, or 20, whatever is bigger.

AttachmentSize
554978-1.component_ui_sufficient_delta.patch 1.55 KB

#2

hunmonk - August 21, 2009 - 21:53
Status:needs review» reviewed & tested by the community

seems like a nice future-proof solution.

#3

dww - August 21, 2009 - 21:58
Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks for the review. It'd be nice to roll this out officially on d.o... maybe once there are a few other project_issue bugs fixed.

#4

dww - August 21, 2009 - 23:29

Synced code to SVN and deployed revision 1660 on d.o.

#5

System Message - September 4, 2009 - 23:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.