Posted by nedjo on August 20, 2009 at 7:57pm
4 followers
| Project: | Tabs (jQuery UI tabs) |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
To get gmap etc. working we now move tabs off to the left rather than setting display:none but in some cases the offset isn't large enough and content is displayed onscreen.
Need to increase the offset.
Comments
#1
Applied a fix.
#2
I was just about to submit an issue when I discovered the fix.
Worked liked a charm. Really appreciate it!
#3
This was the new issue I noticed in #366049: Certain field elements cause add/edit forms to be hidden. My tabs display correctly with the current dev version of Tabs, but there is a small problem. I have some pretty lengthy forms and this method of displaying the tabs results in pages with very large empty spaces at the bottom of the page. This is due to the fact that, while the hidden tab content is rendered off screen, it is still placed at the bottom of the onscreen content.
I have attached a patch that adds a top offset and uses percentage based offsets which should accommodate any content regardless of how wide or long it is.
#4
Scratch the whole percentage thing, it wasn't working as well as I first thought. A top offset still needs to be added though. I just used the same value as the left offset, but someone who makes a sufficiently large enough tab could get empty space showing up regardless of what the offset is.
A larger offset makes these problems more uncommon, but only by calculating the pixel size of the tabsets can we ensure this is never a problem. Just something to think about.
#5
Thanks, increased the offsets and set visibility to hidden.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.